From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: X86: remove read buffer for mmio read
Date: Tue, 10 Jul 2012 19:04:29 +0300 [thread overview]
Message-ID: <4FFC528D.8040900@redhat.com> (raw)
In-Reply-To: <20120710130149.GE23898@redhat.com>
On 07/10/2012 04:01 PM, Gleb Natapov wrote:
> On Tue, Jul 10, 2012 at 03:50:39PM +0300, Avi Kivity wrote:
> > On 07/10/2012 01:48 PM, Gleb Natapov wrote:
> > > > > >
> > > > > But the code is already here, why drop it?
> > > >
> > > > The read cache is not effective for multiple disjunct reads.
> > > What do you mean?
> >
> > If an instruction reads from several sources in mmio, then the first
> > read will be flushed from the cache by the second read. So if we need a
> > third read, we'll have to exit for the first again.
> >
> The cache is flashed only before instruction decode, never during
> emulation.
Oh, I misread the code.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2012-07-10 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 9:02 [PATCH 1/2] KVM: X86: remove read buffer for mmio read Xiao Guangrong
2012-07-09 9:03 ` [PATCH 2/2] KVM: X86: introduce set_mmio_exit_info Xiao Guangrong
2012-07-09 11:15 ` [PATCH 1/2] KVM: X86: remove read buffer for mmio read Avi Kivity
2012-07-09 11:23 ` Gleb Natapov
2012-07-09 12:48 ` Avi Kivity
2012-07-09 12:49 ` Avi Kivity
2012-07-09 13:23 ` Xiao Guangrong
2012-07-09 13:26 ` Gleb Natapov
2012-07-09 13:34 ` Avi Kivity
2012-07-10 10:36 ` Gleb Natapov
2012-07-10 10:45 ` Avi Kivity
2012-07-10 10:48 ` Gleb Natapov
2012-07-10 12:50 ` Avi Kivity
2012-07-10 13:01 ` Gleb Natapov
2012-07-10 16:04 ` Avi Kivity [this message]
2012-07-09 13:26 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFC528D.8040900@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).