* [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
@ 2012-07-11 6:36 Dan Carpenter
2012-07-11 23:55 ` Chanwoo Choi
2012-07-12 17:30 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-07-11 6:36 UTC (permalink / raw)
To: MyungJoo Ham, Mark Brown; +Cc: Chanwoo Choi, linux-kernel, kernel-janitors
Smatch complains about this. I don't have a way to test this, but it
does look like we should unlock on error here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index b068bc9..4782884 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
if (ret != 0) {
dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
+ mutex_unlock(&info->lock);
return IRQ_NONE;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 [patch] Extcon: Arizona: unlock on an error in arizona_micdet() Dan Carpenter
@ 2012-07-11 23:55 ` Chanwoo Choi
2012-07-12 17:30 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2012-07-11 23:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Mark Brown, linux-kernel, kernel-janitors
Hi Dan,
On 07/11/2012 03:36 PM, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index b068bc9..4782884 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -154,6 +154,7 @@ static irqreturn_t arizona_micdet(int irq, void *data)
> ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
> if (ret != 0) {
> dev_err(arizona->dev, "Failed to read MICDET: %d\n", ret);
> + mutex_unlock(&info->lock);
> return IRQ_NONE;
> }
>
This patch is right.
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] Extcon: Arizona: unlock on an error in arizona_micdet()
2012-07-11 6:36 [patch] Extcon: Arizona: unlock on an error in arizona_micdet() Dan Carpenter
2012-07-11 23:55 ` Chanwoo Choi
@ 2012-07-12 17:30 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-07-12 17:30 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Chanwoo Choi, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On Wed, Jul 11, 2012 at 09:36:02AM +0300, Dan Carpenter wrote:
> Smatch complains about this. I don't have a way to test this, but it
> does look like we should unlock on error here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acke-dby: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-12 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 6:36 [patch] Extcon: Arizona: unlock on an error in arizona_micdet() Dan Carpenter
2012-07-11 23:55 ` Chanwoo Choi
2012-07-12 17:30 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox