From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932888Ab2GLIL7 (ORCPT ); Thu, 12 Jul 2012 04:11:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6921 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104Ab2GLILu (ORCPT ); Thu, 12 Jul 2012 04:11:50 -0400 Message-ID: <4FFE86A4.2010809@redhat.com> Date: Thu, 12 Jul 2012 11:11:16 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Raghavendra K T CC: Christian Borntraeger , "H. Peter Anvin" , Thomas Gleixner , Marcelo Tosatti , Ingo Molnar , Rik van Riel , S390 , Carsten Otte , KVM , chegu vinod , "Andrew M. Theurer" , LKML , X86 , Gleb Natapov , linux390@de.ibm.com, Srivatsa Vaddagiri , Joerg Roedel , Christian Ehrhardt , Alexander Graf , Paul Mackerras , Benjamin Herrenschmidt Subject: Re: [PATCH RFC 0/2] kvm: Improving directed yield in PLE handler References: <20120709062012.24030.37154.sendpatchset@codeblue> <4FFA8E5E.3070108@de.ibm.com> <4FFD422B.9060008@redhat.com> <4FFD52CD.7040403@de.ibm.com> <4FFD5DA3.3010001@redhat.com> <4FFD6100.8050202@de.ibm.com> <4FFD65E0.500@redhat.com> <4FFE5C9C.9070001@linux.vnet.ibm.com> In-Reply-To: <4FFE5C9C.9070001@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/12/2012 08:11 AM, Raghavendra K T wrote: >> Ah, I thouht you objected to the CONFIG var. Maybe call it >> cpu_relax_intercepted since that's the linuxy name for the instruction. >> > > Ok, just to be on same page. 'll have : > 1. cpu_relax_intercepted instead of pause_loop_exited. > > 2. CONFIG_KVM_HAVE_CPU_RELAX_INTERCEPT which is unconditionally > selected for x86 and s390 > > 3. make request mechanism to clear cpu_relax_intercepted. > > ('ll do same thing for s390 also but have not seen s390 code using > request mechanism, so not sure if it ok.. otherwise we have to clear > unconditionally for s390 before guest enter and for x86 we have to move > make_request back to vmx/svm). > will post V3 with these changes. You can leave the s390 changes to the s390 people; just make sure the generic code is ready. -- error compiling committee.c: too many arguments to function