* [PATCH] usb: host: tegra: pass correct pointer in ehci_setup()
@ 2012-07-12 8:36 Laxman Dewangan
2012-07-12 9:12 ` Venu Byravarasu
2012-07-12 14:31 ` Alan Stern
0 siblings, 2 replies; 3+ messages in thread
From: Laxman Dewangan @ 2012-07-12 8:36 UTC (permalink / raw)
To: stern, gregkh
Cc: linux-usb, linux-kernel, linux-tegra, swarren, vbyravarasu,
Laxman Dewangan
The ehci_setup() require the pointer of usb_hcd.
Passing the correct pointer in place of ehci_hcd
pointer.
This is side effetct of change:
commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
Author: Alan Stern <stern@rowland.harvard.edu>
EHCI: centralize controller initialization
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/usb/host/ehci-tegra.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 9e44b1f..d2a7c95 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -285,7 +285,7 @@ static int tegra_ehci_setup(struct usb_hcd *hcd)
/* switch to host mode */
hcd->has_tt = 1;
- retval = ehci_setup(ehci);
+ retval = ehci_setup(hcd);
if (retval)
return retval;
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: host: tegra: pass correct pointer in ehci_setup()
2012-07-12 8:36 [PATCH] usb: host: tegra: pass correct pointer in ehci_setup() Laxman Dewangan
@ 2012-07-12 9:12 ` Venu Byravarasu
2012-07-12 14:31 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Venu Byravarasu @ 2012-07-12 9:12 UTC (permalink / raw)
To: Laxman Dewangan
Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Stephen Warren
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>
Tested-by: Venu Byravarasu <vbyravarasu@nvidia.com>
On Thursday 12 July 2012 02:06 PM, Laxman Dewangan wrote:
> The ehci_setup() require the pointer of usb_hcd.
> Passing the correct pointer in place of ehci_hcd
> pointer.
>
> This is side effetct of change:
> commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
> Author: Alan Stern <stern@rowland.harvard.edu>
>
> EHCI: centralize controller initialization
>
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> drivers/usb/host/ehci-tegra.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 9e44b1f..d2a7c95 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -285,7 +285,7 @@ static int tegra_ehci_setup(struct usb_hcd *hcd)
> /* switch to host mode */
> hcd->has_tt = 1;
>
> - retval = ehci_setup(ehci);
> + retval = ehci_setup(hcd);
> if (retval)
> return retval;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: tegra: pass correct pointer in ehci_setup()
2012-07-12 8:36 [PATCH] usb: host: tegra: pass correct pointer in ehci_setup() Laxman Dewangan
2012-07-12 9:12 ` Venu Byravarasu
@ 2012-07-12 14:31 ` Alan Stern
1 sibling, 0 replies; 3+ messages in thread
From: Alan Stern @ 2012-07-12 14:31 UTC (permalink / raw)
To: Laxman Dewangan
Cc: gregkh, linux-usb, linux-kernel, linux-tegra, swarren,
vbyravarasu
On Thu, 12 Jul 2012, Laxman Dewangan wrote:
> The ehci_setup() require the pointer of usb_hcd.
> Passing the correct pointer in place of ehci_hcd
> pointer.
>
> This is side effetct of change:
> commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
> Author: Alan Stern <stern@rowland.harvard.edu>
>
> EHCI: centralize controller initialization
>
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Argh! You're perfectly right, of course. I thought I had checked all
those calls carefully.
Anyway, two other calls need to be fixed as well. I'll resubmit your
patch, with the other two fixes included. Okay?
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-12 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 8:36 [PATCH] usb: host: tegra: pass correct pointer in ehci_setup() Laxman Dewangan
2012-07-12 9:12 ` Venu Byravarasu
2012-07-12 14:31 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox