From: Chanwoo Choi <cw00.choi@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: gregkh@linuxfoundation.org, sameo@linux.intel.com,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break
Date: Fri, 13 Jul 2012 08:46:39 +0900 [thread overview]
Message-ID: <4FFF61DF.4030309@samsung.com> (raw)
In-Reply-To: <20120712161621.GB7256@opensource.wolfsonmicro.com>
On 07/13/2012 01:16 AM, Mark Brown wrote:
> On Thu, Jul 12, 2012 at 01:32:27PM +0900, Chanwoo Choi wrote:
>> This patch modify 'Kconfig' of EXTCON Subsystem to support either
>> active or inactive of EXTCON Subsystem. The various subsystem refer
>> to EXTCON subsystem for controlling external connector, so core class
>> of EXTCON should be included in kernel image. If EXTCON subsystem is
>> builded with MODULE, other subsystem have build break because of
>> linking the core class of EXTCON.
>
> By this logic very little in the kernel should be a module. We usually
> only force things to be built in if there's a technical need for it like
> init ordering constraints. Generally this is just a case of making sure
> the Kconfig stuff is set up with appropriate dependencies.
As you said, I will fix it.
Thank you,
Chanwoo Choi
prev parent reply other threads:[~2012-07-12 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 4:32 [PATCH] extcon: Remove CONFIG_EXTCON_MODULE config to fix build break Chanwoo Choi
2012-07-12 15:36 ` Greg KH
2012-07-12 23:45 ` Chanwoo Choi
2012-07-12 16:16 ` Mark Brown
2012-07-12 23:46 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF61DF.4030309@samsung.com \
--to=cw00.choi@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox