From: pa@panix.com (Pierre Asselin)
To: pa@panix.com, javierm@redhat.com
Cc: tzimmermann@suse.de, pa@panix.com, linux-kernel@vger.kernel.org,
jfalempe@redhat.com, hdegoede@redhat.com,
dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch,
ardb@kernel.org
Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated
Date: Thu, 13 Apr 2023 01:13:05 +0000 [thread overview]
Message-ID: <4PxhQn3zK1zcbc@panix1.panix.com> (raw)
In-Reply-To: <9e6fff69b09b36cbdd96499cd0015154.squirrel@mail.panix.com>
After careful reading of the comments in f35cd3fa7729, would this
be an appropriate fix ? Does it still address all the issues raised
by Thomas ?
(not tested)
diff --git a/drivers/firmware/sysfb_simplefb.c b/drivers/firmware/sysfb_simplefb.c
index 82c64cb9f531..9f5299d54732 100644
--- a/drivers/firmware/sysfb_simplefb.c
+++ b/drivers/firmware/sysfb_simplefb.c
@@ -56,10 +56,11 @@ __init bool sysfb_parse_mode(const struct screen_info *si,
* don't specify alpha channels.
*/
if (si->lfb_depth > 8) {
- bits_per_pixel = max(max3(si->red_size + si->red_pos,
+ bits_per_pixel = max3(max3(si->red_size + si->red_pos,
si->green_size + si->green_pos,
si->blue_size + si->blue_pos),
- si->rsvd_size + si->rsvd_pos);
+ si->rsvd_size + si->rsvd_pos,
+ si->lfb_depth);
} else {
bits_per_pixel = si->lfb_depth;
}
next prev parent reply other threads:[~2023-04-13 1:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:02 [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated Javier Martinez Canillas
2023-04-12 16:18 ` Pierre Asselin
2023-04-12 17:31 ` Javier Martinez Canillas
2023-04-12 18:12 ` Pierre Asselin
2023-04-12 18:24 ` Javier Martinez Canillas
2023-04-12 18:51 ` Pierre Asselin
2023-04-12 21:04 ` Javier Martinez Canillas
2023-04-12 21:40 ` Javier Martinez Canillas
2023-04-12 21:53 ` Pierre Asselin
2023-04-12 22:09 ` Javier Martinez Canillas
2023-04-12 23:13 ` Pierre Asselin
2023-04-13 1:13 ` Pierre Asselin [this message]
2023-04-13 1:34 ` Pierre Asselin
2023-04-17 8:15 ` Thomas Zimmermann
2023-04-17 8:58 ` Javier Martinez Canillas
2023-04-17 9:15 ` Thomas Zimmermann
2023-04-17 9:29 ` Javier Martinez Canillas
2023-04-13 7:08 ` Javier Martinez Canillas
2023-04-13 16:24 ` Pierre Asselin
2023-04-13 16:34 ` Javier Martinez Canillas
2023-04-13 17:17 ` Pierre Asselin
2023-04-13 18:04 ` Javier Martinez Canillas
2023-04-13 6:54 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4PxhQn3zK1zcbc@panix1.panix.com \
--to=pa@panix.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=javierm@redhat.com \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox