From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Niranjan Dighe'" <niranjan.dighe@gmail.com>,
"Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Patrick Boettcher" <patrick.boettcher@posteo.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
"Mike Rapoport" <mike.rapoport@gmail.com>,
Matthew Tyler <matt.tyler@flashics.com>,
"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [lustre-devel] [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse
Date: Tue, 5 Jan 2016 20:54:16 +0000 [thread overview]
Message-ID: <4a016e0876fd4e54ae77763be3667209@EXCHCS32.ornl.gov> (raw)
In-Reply-To: <CADCM0GJSpbansEjGRcqVX1H2jQUhOC2kNFxk_15Ffo-=VyGq=g@mail.gmail.com>
>>>2. Is it OK to hardcode the appropriate gfp_t flags for the
>>>IOC_LIBCFS_MEMHOG, as the userspace
>>>seems to be taking the decision about the page allocation
>>>zone/strategy, is this what is intended?
>>
>> The memhog functionality is used to introduce memory pressure on a client
>> or server during operation to test error handling as well as memory
>> allocation deadlocks (e.g. GFP_KERNEL used where GFP_NOFS should be used).
>> There are other ways to do this in the kernel today, so all of the memhog
>> code could just be deleted I think.
>>
>> This looks like kportal_memhog_alloc(), kportal_memhog_free(),
>> IOC_LIBCFS_MEMHOG, and struct libcfs_device_userstate could be removed.
>>
>>
>> Cheers, Andreas
>>
>Thanks Andreas, I will send out a separate patch with the cleanup as
>you suggested.
I missed this email. I just sent the cleanup patches a bit ago.
next prev parent reply other threads:[~2016-01-05 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 17:08 [PATCH] staging: lustre/lustre/libcfs: Fix type mismatch reported by sparse Niranjan Dighe
2015-12-21 23:44 ` Greg Kroah-Hartman
2015-12-22 13:05 ` Niranjan Dighe
2015-12-22 15:26 ` Greg Kroah-Hartman
2015-12-22 22:04 ` Dilger, Andreas
2015-12-23 6:27 ` Niranjan Dighe
2016-01-05 20:54 ` Simmons, James A. [this message]
2016-01-05 15:43 ` [lustre-devel] " Simmons, James A.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a016e0876fd4e54ae77763be3667209@EXCHCS32.ornl.gov \
--to=simmonsja@ornl.gov \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=matt.tyler@flashics.com \
--cc=mike.rapoport@gmail.com \
--cc=niranjan.dighe@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=patrick.boettcher@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox