From: Denis Efremov <efremov@linux.com>
To: Markus Elfring <Markus.Elfring@web.de>, linux-wimax@intel.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*() condition
Date: Sat, 31 Aug 2019 18:59:53 +0300 [thread overview]
Message-ID: <4a064df8-9b44-8380-d7c5-8a94086c3a52@linux.com> (raw)
In-Reply-To: <c9d3f0e1-d2c9-aedb-385c-82a8cb077253@web.de>
On 31.08.2019 14:25, Markus Elfring wrote:
>> pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
>> - if (unlikely(WARN_ON(pad_buf == NULL
>> - || pad_buf == TAIL_FULL))) {
>> + if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {
>
> How do you think about to use the following code variant?
>
> + if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {
>
Well, I thought about it, because coccinelle warns about style here.
But this condition looks more symmetric with direct comparison.
I've decided that it will be better to save the original style.
Thanks,
Denis
next prev parent reply other threads:[~2019-08-31 15:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 16:50 [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Denis Efremov
2019-08-29 16:50 ` [PATCH v3 02/11] drm/msm: remove unlikely() from WARN_ON() conditions Denis Efremov
2019-09-04 4:13 ` Bjorn Andersson
2019-08-29 16:50 ` [PATCH v3 03/11] net/mlx5e: Remove unlikely() from WARN*() condition Denis Efremov
2019-08-29 21:23 ` Saeed Mahameed
2019-08-31 2:50 ` David Miller
2019-08-29 16:50 ` [PATCH v3 04/11] xen/events: Remove unlikely() from WARN() condition Denis Efremov
2019-08-29 16:50 ` [PATCH v3 05/11] fs: remove unlikely() from WARN_ON() condition Denis Efremov
2019-08-29 16:50 ` [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*() condition Denis Efremov
2019-08-31 11:25 ` Markus Elfring
2019-08-31 15:59 ` Denis Efremov [this message]
2019-08-29 16:50 ` [PATCH v3 07/11] xfs: remove unlikely() from WARN_ON() condition Denis Efremov
2019-08-29 21:22 ` Darrick J. Wong
2019-08-30 5:37 ` Christoph Hellwig
2019-08-29 16:50 ` [PATCH v3 08/11] IB/hfi1: Remove unlikely() from IS_ERR*() condition Denis Efremov
2019-08-29 16:50 ` [PATCH v3 09/11] Input: alps - remove " Denis Efremov
2019-08-29 17:50 ` Dmitry Torokhov
2019-08-31 15:25 ` Pali Rohár
2019-08-31 15:50 ` Denis Efremov
2019-08-31 20:32 ` Joe Perches
2019-08-31 21:03 ` Dmitry Torokhov
2019-08-29 16:50 ` [PATCH v3 10/11] udp: Remove " Denis Efremov
2019-08-29 16:50 ` [PATCH v3 11/11] ntfs: remove (un)?likely() from IS_ERR() conditions Denis Efremov
2019-08-31 9:15 ` [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Markus Elfring
2019-08-31 15:54 ` Denis Efremov
2019-08-31 16:45 ` Markus Elfring
2019-08-31 17:07 ` Denis Efremov
2019-08-31 17:26 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a064df8-9b44-8380-d7c5-8a94086c3a52@linux.com \
--to=efremov@linux.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=inaky.perez-gonzalez@intel.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox