Re: [PATCH v13 2/2] KVM: s390: resetting the Topology-Change-Report

Janosch Frank
2022-07-14T14:12:29Z

On 7/14/22 12:18, Pierre Morel wrote:
> During a subsystem reset the Topology-Change-Report is cleared.
>
> Let's give userland the possibility to clear the MTCR in the case
> of a subsystem reset.
>
> To migrate the MTCR, we give userland the possibility to
> query the MTCR state.
>
> We indicate KVM support for the CPU topology facility with a new
> KVM capability: KVM_CAP_S390_CPU_TOPOLOGY.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>

Nit below, but:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -1158,6 +1158,7 @@ struct kvm_ppc_resize_hpt {
> #define KVM_CAP_SYSTEM_EVENT_DATA 215
> #define KVM_CAP_ARM_SYSTEM_SUSPEND 216
> #define KVM_CAP_S390_PROTECTED_DUMP 217
> +#define KVM_CAP_S390_CPU_TOPOLOGY 218
> #define KVM_CAP_S390_ZPCI_OP 221

Using 222 and moving it a line down might make more sense as 218 is
KVM_CAP_X86_TRIPLE_FAULT_EVENT.

Can you fix this and push both patches to devel?
Also send the fixed patch as a reply to this message so I can pick it
from the list.

next and devel have diverted a bit so I will need to fix this up for
next, same for the Documentation entry which will be 6.39 instead of 6.38.

>
> #ifdef KVM_CAP_IRQ_ROUTING