From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jyan Chou <jyanchou@realtek.com>,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
jh80.chung@samsung.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
benchuanggli@gmail.com
Subject: Re: [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver
Date: Wed, 18 Oct 2023 16:24:56 +0200 [thread overview]
Message-ID: <4a20bcf9-c0d7-45e9-ab19-e7e3bb073601@kernel.org> (raw)
In-Reply-To: <20231018055326.18256-5-jyanchou@realtek.com>
On 18/10/2023 07:53, Jyan Chou wrote:
> Document the device-tree bindings for Realtek SoCs mmc driver.
>
> Signed-off-by: Jyan Chou <jyanchou@realtek.com>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Also, coding style of your example is messy.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-18 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:53 [PATCH V2][0/4] Add DesignWare Mobile mmc driver Jyan Chou
2023-10-18 5:53 ` [PATCH V2][1/4] mmc: solve DMA boundary limitation of CQHCI driver Jyan Chou
2023-10-19 9:00 ` kernel test robot
2023-10-19 13:00 ` kernel test robot
2023-10-18 5:53 ` [PATCH V2][2/4] mmc: Add Synopsys DesignWare mmc cmdq host driver Jyan Chou
2023-10-18 5:53 ` [PATCH V2][3/4] mmc: Add dw mobile mmc cmdq rtk driver Jyan Chou
2023-10-18 5:53 ` [PATCH V2][4/4] mmc: Add dt-bindings for realtek mmc driver Jyan Chou
2023-10-18 14:24 ` Krzysztof Kozlowski [this message]
2023-10-20 5:18 ` Jyan Chou [周芷安]
2023-10-21 11:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a20bcf9-c0d7-45e9-ab19-e7e3bb073601@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=benchuanggli@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=jyanchou@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox