From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65C822FFDDB for ; Tue, 18 Nov 2025 14:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763476219; cv=none; b=cIS/KyK+w+/rxkA1jkzhmXAotXt5VPxwrfG9e3oCEjzcvtiJNts3zm3iiyY99aNFpXEwSUzrJNXtCluyKQxKRG1xl0sDUHz1ZzPe9S9nYkKrBV+kWe8z19b0tExX+26Is7le/i0rjI6WkG6ejLNesdY9LalNWvdEWybSXSYVegk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763476219; c=relaxed/simple; bh=AcnGX8ANmx00qdNl11G0N+EdinX9DGDDhNDUIL1OQV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TKBET0zNWtH4x0mVHOsoHlXH4lHwUfKATaGbXkuOOFfaNcAb8Fy0LLWWCmUodKIFRNImIkip0ng9UJN4VqPs8Jjks/1vsj/UpdQ1/Ib4VwGylAoPLczwunWY8DJBlpIdVKZl2kyoMzWVmryDfx0MnT8jbJlfKOZSZ6TqDP6693E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RFNFXiZ0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QXmhudhE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RFNFXiZ0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QXmhudhE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763476216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3eRIY/NbZeEoJzxpOIjcuTXUY4zJKOGkqyWddqMp990=; b=RFNFXiZ0iXKn/2ZG69RsSsHuMJSf+NJpq4L3kJjME/GamHIFvd36CqGNe5VAoI6+torBjv ZFIvjKjJ1S30CnUMl7ohpE8lxMU7d+ErNrQz3JTwVrSJQx/P2hNHND1WoUuw1a0eIfR7to daJ4LazVIc4uuMQikU66pv0Jp8BjrDQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65--p3CZZhJNKeOJ_oKdOGzHQ-1; Tue, 18 Nov 2025 09:30:14 -0500 X-MC-Unique: -p3CZZhJNKeOJ_oKdOGzHQ-1 X-Mimecast-MFC-AGG-ID: -p3CZZhJNKeOJ_oKdOGzHQ_1763476213 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42b3c965ce5so3823439f8f.2 for ; Tue, 18 Nov 2025 06:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763476213; x=1764081013; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3eRIY/NbZeEoJzxpOIjcuTXUY4zJKOGkqyWddqMp990=; b=QXmhudhEG//Yvv51l5Z16C6DPXDj4L0iTMkPLzag3ROiqKEggSgEs/OIRALWSoRDRi 7vqdyJgzHvKxXgbXZd9eb+2XwXQkG/vNsAOmO6nKHmuobfWCUEvPo5VMc3Pb2n6PGw7/ NrZrksyJX+Nm2i//gGqx0JYpnmdjM4Aj3ZupF/CZyW5QNAp3QvFwKwX3zZiC+UH1+KCD hoKYqRxq7ZuzaFAuV+Plck0CD/ulAd6Ur6PjmHZ4X/9dg8W31Hm9jvr/0mpidSaQIUg4 VugzGXeiZpFR+kbnvt/1EBK8yA0zvXyOn2jyKyLSAIJgxG6v+M8rFiM0vXHtL3U5rfSM k/nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763476213; x=1764081013; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3eRIY/NbZeEoJzxpOIjcuTXUY4zJKOGkqyWddqMp990=; b=SuGsOJazAg4yptg0RCJdUYIIB6Np3p1M8AZ59Y9fXPB0w7A6lI0bN3hFWkRKL8bt8g FOEEAiPMnkGE+r7Exy/aJ/4/QlBwBdOOkMThZwoKKhXY0ygnuu0Lqb7Si76NCbskvW1T p6QsIGTSatfmxrlYsBUmVitv/Y3ZrYfYbaXkirCtzkCmCFZ8Tcx9mu5rSCD/jvrF9gVH pqZGTHmoSIXvmWOFDJd2iomhzL9OTDGNxM3V/e/2SI1SY4Md8th7A3aoWGWDO0yHuhI/ a3CfOPRdtYCGuteYaBBFpVaYnePxWrF1zQoPsZqezlwwoLPE+UQJk2EaLkfwg4MidS9G 2ddA== X-Forwarded-Encrypted: i=1; AJvYcCUYse8ZdaxC19BS3KniAho9w8TQV1ykYuquJi5XHmiG9vbM0TSxpIFq8+dTANZM/ZNL4JMrQ2fsZF7ccVA=@vger.kernel.org X-Gm-Message-State: AOJu0YyO69+bpSSevz0HtHDWiuIh7uZfZTVwNfp8R5ZFqJOn3AGf8aQl M2RMtQEz521XkxbSU8/J1R44eAEjVS+BY5Xsi0B/lrEwQEKvtiC1j7pEbr+yUm/2YO28WlHs1yK pOZJwKC4W3KaBnXUPmhizUZm6h+XiQO5j95pi9OpLXX6aBlYKRgYm068mTuTlU2FsaA== X-Gm-Gg: ASbGnct09KEA9QXNX9vJbZkK25EAOj+Kgl2lNDPBEO+BYBscYnpv3rawBjCmd0QHar7 OlaJ7Z6/RAG0p+IFsS9TqHisb98FbG32gS215W6B6OeGRVaBfaw+R3Go3QMXm/xjmVVjTgv/wzU f/gTneh9QdtVjG9CDEmPpo34v2oMfSsLp/72+6AR2NTmYT/zl1WDxr5GYmEWHA1l6SltB5rl0qN gK3TxdXq/2dAhvtSHMKQUbyStAALOy/8Sz42NFvmzxr6dUC3UOPUw0mjp6+wq4IM+4lUOdIFAd1 2X1aTip9Ysu4hz1H05Y3se0P7u53NOe4xeckyoBy1lOSr7URdSyMykphD8cXKGfUHtA8viiVPmQ Jz1B+S2d9KtBm X-Received: by 2002:a05:6000:4186:b0:429:92d8:3371 with SMTP id ffacd0b85a97d-42b59342b99mr14525631f8f.11.1763476212632; Tue, 18 Nov 2025 06:30:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwm2ThNaD3qGGBsOApPqujAYKRByi04FEJdieN5aJJjweY+ug15q24nDRRxPxeQEH6CYkCcw== X-Received: by 2002:a05:6000:4186:b0:429:92d8:3371 with SMTP id ffacd0b85a97d-42b59342b99mr14525592f8f.11.1763476212191; Tue, 18 Nov 2025 06:30:12 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e85e6fsm32541019f8f.18.2025.11.18.06.30.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 06:30:11 -0800 (PST) Message-ID: <4a3a8ba2-2535-461d-a0a5-e29873f538a4@redhat.com> Date: Tue, 18 Nov 2025 15:30:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: stmmac: add clk_prepare_enable() error handling To: Pavel Zhigulin , Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , Maxime Chevallier , Inochi Amaoto , Quentin Schulz , Joe Hattori , Rayagond Kokatanur , Giuseppe CAVALLARO , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20251114142351.2189106-1-Pavel.Zhigulin@kaspersky.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251114142351.2189106-1-Pavel.Zhigulin@kaspersky.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/25 3:23 PM, Pavel Zhigulin wrote: > The driver previously ignored the return value of 'clk_prepare_enable()' > for both the CSR clock and the PCLK in 'stmmac_probe_config_dt()' function. > > Add 'clk_prepare_enable()' return value checks. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: bfab27a146ed ("stmmac: add the experimental PCI support") > Signed-off-by: Pavel Zhigulin > --- > v2: Fix 'ret' value initialization after build bot notification. > v1: https://lore.kernel.org/all/20251113134009.79440-1-Pavel.Zhigulin@kaspersky.com/ > > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 27bcaae07a7f..8f9eb9683d2b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -632,7 +632,9 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > dev_warn(&pdev->dev, "Cannot get CSR clock\n"); > plat->stmmac_clk = NULL; > } > - clk_prepare_enable(plat->stmmac_clk); > + rc = clk_prepare_enable(plat->stmmac_clk); > + if (rc < 0) > + dev_warn(&pdev->dev, "Cannot enable CSR clock: %d\n", rc); > } > > plat->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); > @@ -640,7 +642,12 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > ret = plat->pclk; > goto error_pclk_get; > } > - clk_prepare_enable(plat->pclk); > + rc = clk_prepare_enable(plat->pclk); > + if (rc < 0) { > + ret = ERR_PTR(rc); > + dev_err(&pdev->dev, "Cannot enable pclk: %d\n", rc); > + goto error_pclk_get; > + } It looks like the driver is supposed to handle the IS_ERR_OR_NULL(plat->pclk) condition. This check could cause regression on existing setup currently failing to initialize the (optional) clock and still being functional. I *think* we are better off without the added checks. /P