From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D4CD37C91A for ; Wed, 4 Mar 2026 08:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772614684; cv=none; b=EsJtqjkiC5710z6Gaz2H6dtBfNxuTTtN06/i0iXqnjcZ+SsxeN6vSUzrDbimOiwmy8wlfKgmVRmfhlQaexi6FAo7691k9KC/x5d+gUeIVWCHKOuBgzv6bgby20GNIW81aaO2Wk3rCyVx2hcHBgXCO4o32N76w49gZhW62rLuipk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772614684; c=relaxed/simple; bh=YNyzheyMXouN8Lf/ico2jv5x4+uFyMuodyQ++FAMW8g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qIBoEHTaVKCPs0PPV82/N4j0AHFJjJCz2pd3Mth+/U+PezhKXpqf4JLoLvIotjV8rtF5czEAcDVYNFyKU4Ldr9keGQKL5ZTYdAkPD+MAyZDb6QBe793dByHOrKjq0D16GZ+ynaYMKsDUIRV0PnpNRnfgrYKNl8pZUIOafAZXAm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Uk0rvhxu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H/YzFH8C; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Uk0rvhxu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H/YzFH8C" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245SOlx2306022 for ; Wed, 4 Mar 2026 08:58:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= niOuDWaqN4TxIlYkrKh6EztHOaj9yjtzNsL8ODj5nqM=; b=Uk0rvhxuuWKguEN2 F5lDCz0rki4FrqwhkyE5Z7ESRTqyzzZl3naodJuBH98RNZtitzWyTC5JucEXC2Ul /GpGkxS7fPJU7Z5oI2g5g0rSbffff6oSI8rP+CwtoEoXRaGkAWc5+g1auXJKBjyy kWdh71oLAFD0AWTal03j2F/f+kIt/efFRqmAzBkvqoG6BTCdmvdD81QNlWMzeWHG vCWJXRuCyEC5U3p+NBsecVWLT6BzuAjmcEruLQ9poFn05lGcNBcCxPRCeJGdLDRU tpzU61KR7idevCJZFiICZIVo8J3bERB4SBu5USMWvwnLjz7+/nHC19atHZgqVSD4 +jA8Mg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpau8seaw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 08:58:02 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70c91c8b0so553759785a.2 for ; Wed, 04 Mar 2026 00:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772614682; x=1773219482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=niOuDWaqN4TxIlYkrKh6EztHOaj9yjtzNsL8ODj5nqM=; b=H/YzFH8CySbR9Oy+FW8IfFjTBUVU5R+9MUrhyuzBuMQn9i24IISXojHt4H+4WD5Ha8 AbpN3ThWhS9/POFuoEHbdjHojXL2fl9BzR5LJFmiLQe2y4ORE0gu37/TkgkKp9HLmack fW5HWUbsRAelLszA3xA/3DwMT1EVMNIJRrnEryLOuSZTrq0XDtS09p6+Eaw8YEjAGaEi fa4go81HfpxduWSxPWhCgAGvZj9JS/3DhXYsFSCdSGo2jcKPKB6NFWwzB8WZnBZsB+9k V9lrxAPja7l5WLmxQBWhGRhwt6Vjtb07QtcIxtzh+6bAd0PAcoWjwqi3C30a6QUCvmT+ X16g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772614682; x=1773219482; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=niOuDWaqN4TxIlYkrKh6EztHOaj9yjtzNsL8ODj5nqM=; b=IUHlmidnSldbsuz44r4BI5/xjxUcy4l/8CuwTNhTRkbbmKdq9Fr0AJmf4dJPVJux9t +P5mVeb0A7VdsDu2ieSbZEDMJEuqMtfSC3YVV/abDfQDXArZWQ8LbGPnHqwcCgl7Wq5w folxfznudbn/xaKCHweMsVU0/FAr5rE5tV4Ntqt0wl8at3V+SUElaLOg/2CjKmng6eot cPoKsR9me/oEcC6i6QzGYEqpCE4z/+TxP9JLrTUcW1sgGpqoTxQIb9GfOeBK9XHuEdBV 8SY0V51CDGQr3J0Lgd3Kfh1dgbQanSDQtifOXzoQGY11lHS8fvq3dTsG+ci/l2ygojD9 kT/g== X-Forwarded-Encrypted: i=1; AJvYcCXPbSq9Z5SzsaRyPAPaVZXAxEdZ7W45JH2JJLp6A/2oV27dV9AGE3vBiYVS1GgnaNb8Pre7C8UM1gb9t+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/1HIrdlgja+iSB6wBA32Ll9bb/ruQw2319V+cU7wgB9+sdd5H 45nqXyhqRnx5K33vz3686zVuIrsMrFX5Qun6z8WdJM395Y9tOWUYV/+g1Fr+8asdG/W814Lvy7z 0xW8gcoAWuPfgaAjdX6G/uWMdzZ89sGCYCdII0tbY51lmiKbe6cDH2kjq4nga/oEVYJM= X-Gm-Gg: ATEYQzz+3oxW/NPlaZvHJoiRTyvj8gLkSdud4I2A5vY2qWFRQ5Lx/NY4OtWP0goalLR s3o3kRNnAsynvB2spD/mUrF/5K+yQOSLpVap4ixSAM4R7VNtzgR31ivGxy1IVmYYtaCHtgecrrw sQJquBqlqb1lwnYDI0sS1DVId3Z03+1aRaH3+K50lOaCkUxiOzEgmC0UcZRk8p20IG1MIMIhTMB BERLiQ9HFvPoVoWr18qEJ7BbxL1TgXJ9OV/lRJc4bNabAKKfB3H7h8xlvsVYx3LOWwN2nEKPxwE Y8VgMXJrl7tU2hYD3EzoBE2CNVC3ZW9Als/u56cZtNdhCnNTb3CsOCjpybdiqRyQZfc3rowxHSx 4jMomlDQzUxcKtHUyTcd4uGgq9CnDLFlC0gSp/ifFv2hNpl7qos35EtfHqeeWo48alGmB+qGr99 3t3Gc= X-Received: by 2002:a05:620a:3945:b0:896:ead2:a657 with SMTP id af79cd13be357-8cd5ad9dd70mr122028085a.0.1772614681654; Wed, 04 Mar 2026 00:58:01 -0800 (PST) X-Received: by 2002:a05:620a:3945:b0:896:ead2:a657 with SMTP id af79cd13be357-8cd5ad9dd70mr122026685a.0.1772614681264; Wed, 04 Mar 2026 00:58:01 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabd46753sm5249417a12.8.2026.03.04.00.57.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 00:57:59 -0800 (PST) Message-ID: <4a5be869-1b98-4b76-b483-4fa374bb36bb@oss.qualcomm.com> Date: Wed, 4 Mar 2026 09:57:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/7] media: iris: switch to hardware mode after firmware boot To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Krzysztof Kozlowski , Vishnu Reddy , Hans Verkuil Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Bryan O'Donoghue References: <20260227-kaanapali-iris-v2-0-850043ac3933@oss.qualcomm.com> <20260227-kaanapali-iris-v2-2-850043ac3933@oss.qualcomm.com> <6fe3a1a8-46c7-427c-abb5-2e7366a43392@oss.qualcomm.com> <164928f6-cd29-49e4-8b5e-365f5b0a70e5@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <164928f6-cd29-49e4-8b5e-365f5b0a70e5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=AJS1/0o2 c=1 sm=1 tr=0 ts=69a7f41a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=b2WnVuVpUTZYNMXETCkA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: AU1QV314kagx78B0ZYwu1di4OnNgr_WO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA2NyBTYWx0ZWRfX2f/a6IgZoRrG JbVZ3Fa9m6HvsSoILugrBq0qMRXpJ9UxSf2d23vP4ZR8U3dFE624SfwiBmcAdbrl4UDz+Mz5KtB n87BwTMfc4prsjwgEPyzYvi+CQH0e2g/koYj90OglMvMDBE23EY0gHq4iNYDgR60BVW2MD3yzNh 0gQkV66tT3EVDBTZ5fG7o/6DFWXvwKwcG80+MKe8CwL0+nZqLfKB4XlX/U/XbpbjLXyVRuGgJAJ sHpDfuL7xRWLcqypQqfM3Pulrx/b+9vmFMSQfUWlg71ABD+5LVyDxmF5YovZVuLi+TYZVfjt7YK FpfHOBcpyWFMI6c5tlTOwGUly+y7/D7HGxJZTdm2vRVszvVS1NFtUrSqaLm7Z6WwcMHfW+oTD6Q S+JLm/p4BeqPOdZKlVwgOKJr3T2BRB90Zn9IzQ9vQz+KSDgwIXpTygzk9eU1zGbIf64EXaNkasf 2e2uBSvHXNrDsLczYXw== X-Proofpoint-GUID: AU1QV314kagx78B0ZYwu1di4OnNgr_WO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_04,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040067 On 3/3/26 7:15 PM, Vikash Garodia wrote: > > > On 2/27/2026 10:19 PM, Konrad Dybcio wrote: >> On 2/27/26 3:11 PM, Vikash Garodia wrote: >>> Currently the driver switches the vcodec GDSC to hardware (HW) mode >>> before firmware load and boot sequence. GDSC can be powered off, keeping >>> in hw mode, thereby the vcodec registers programmed in TrustZone (TZ) >>> carry default (reset) values. >>> Move the transition to HW mode after firmware load and boot sequence. >>> >>> The bug was exposed with driver configuring different stream ids to >>> different devices via iommu-map. With registers carrying reset values, >>> VPU would not generate desired stream-id, thereby leading to SMMU fault. >>> >>> For vpu4, when GDSC is switched to HW mode, there is a need to perform >>> the reset operation. Without reset, there are occassional issues of >>> register corruption observed. Hence the vpu GDSC switch also involves >>> the reset. >> >> Is that a characteristic of the hardware (e.g. also seen downstream), or >> is that required with upstream iris only? > > it was found lately with one of vpu4 variant SOC and applicable for all vpu4s. Thanks Konrad