From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBovfQ+fShbb5Wcz4uUT2Rgs2HZvXn3J2DvyIDXfIIXP6oZPuqiCktAJ+WaTAr/rWF1EP5xUb ARC-Seal: i=1; a=rsa-sha256; t=1516255452; cv=none; d=google.com; s=arc-20160816; b=xfPIuJhtINbKgGebtgoKDvsZOtsHK9jD8WjRrdjChVaOiHm7NG6Uiqxh8fjk/+4Hdq IXOqX9KVvZwpdHA/ZS8OH2aKrXI8MPW1vdvQKCwHQYjgf1TWkNIWHyx5PR3PIjuPgk7B vn2+EoNIgSN94J2jvtKqyrVsZ7G5RUG2piDyE6uiB77tbpVLQy05Yxplrd7Ku88599cp e76H/hmTbJUSl0U7WFnKMQL6Em399gdyxwTLk2/RPya3hFWOjD0EjHAf3ifv1cL3z1pp HmspCNqxr8qkHA7M4wyKgNEw5t6sdGEEnhmvGn4jzFIher1KAb5xnQYWFnTa+bHM2QQ7 Ia/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=w9oEzaVMWuh7Lx+0LJYXFWCFCqS5WCznb7zYy9h8ANA=; b=lIga7fxD5v0CnSqEy/hLSawM3RU09J8I1KWhtmqR69kqvCFmfKYTmvI9xDXtP1h0CT Ttdo0hYGRW4IGFAJvo1ygbWuwnInVOXJljzgugYKRVjqUV405ffYbE+ex4uxXbVPhSZ0 zcw7l232mOJkv8cnzgce6qh3IWEWEbC1MQsPxvwi+QkETFi+CI730PEURAcpuapBMEaD qpVVPHp3aHgRyxCXRjkbKQJWz144yk4sXeXCG1ll5dN5194UMwggjhL6H78KYx6pcDTe eb6e9zh3+375MeA8LGrJn4mg6/kKGQM+CC3rO4GRxBJ+3Bi2I4fhl+J8ziBfwTLG2LPN vPEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MNgdI9QA; dkim=pass header.i=@codeaurora.org header.s=default header.b=QtaCZBFU; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MNgdI9QA; dkim=pass header.i=@codeaurora.org header.s=default header.b=QtaCZBFU; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jan 2018 11:34:11 +0530 From: poza@codeaurora.org To: Sinan Kaya Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC In-Reply-To: References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <298df660-1f7d-85ab-51db-11dc5d80cc75@codeaurora.org> Message-ID: <4a68efd464e5debe81db8f7b4ddccc8f@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589909077941202708?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-18 10:52, poza@codeaurora.org wrote: > On 2018-01-17 22:15, Sinan Kaya wrote: >> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >>> + driver = pci_find_dpc_service(udev); >>> +#endif >>> #if IS_ENABLED(CONFIG_PCIEAER) >>> - /* Use the aer driver of the component firstly */ >>> - driver = pci_find_aer_service(udev); >> >> I think we need a pci_find_service function that unifies these two. > > Right now, find_xxx_service are in their respective file and exporting > it. > which makes sense no less than having generic function. > > If I have to change pci_find_service(...., int service_name) then it > has to be somewhere in generic file. > probably portdrv_core.c > > either way I am fine but just thinking out if its really required. > > Regards, > Oza. Should I be doing in next patch-set series ? Regards, Oza.