From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, nuno.sa@analog.com
Cc: Petr Mladek <pmladek@suse.com>, Chris Down <chris@chrisdown.name>,
John Ogness <john.ogness@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Andi Shyti <andi.shyti@kernel.org>,
Jyoti Bhayana <jbhayana@google.com>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers
Date: Thu, 02 May 2024 13:34:23 +0200 [thread overview]
Message-ID: <4a8bf342ecd988f4c3cdeebb6f16da61a60c4454.camel@gmail.com> (raw)
In-Reply-To: <ZifUSKFh2C4VG5QB@smile.fi.intel.com>
On Tue, 2024-04-23 at 18:31 +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 05:20:30PM +0200, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <nuno.sa@analog.com>
> >
> > This is similar to dev_err_probe() but for cases where an ERR_PTR() or
> > ERR_CAST() is to be returned simplifying patterns like:
> >
> > dev_err_probe(dev, ret, ...);
> > return ERR_PTR(ret)
> > or
> > dev_err_probe(dev, PTR_ERR(ptr), ...);
> > return ERR_CAST(ptr)
>
> ...
>
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */
> > +#define dev_err_ptr_probe(dev, ___err, fmt, ...) ({ \
> > + ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__)); \
> > +})
>
> Why ; and hence why ({}) ?
>
> I even believe the compiler may warn if you have double ;; in some cases.
>
Oh yes, no need for any of those...
- Nuno Sá
next prev parent reply other threads:[~2024-05-02 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:20 [PATCH v2 0/4] dev_printk: add dev_errp_probe() helper Nuno Sa via B4 Relay
2024-04-23 15:20 ` [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers Nuno Sa via B4 Relay
2024-04-23 15:31 ` Andy Shevchenko
2024-04-23 15:45 ` Andy Shevchenko
2024-05-02 11:54 ` Nuno Sá
2024-05-02 15:37 ` Andy Shevchenko
2024-05-02 11:34 ` Nuno Sá [this message]
2024-04-23 15:20 ` [PATCH v2 2/4] iio: temperature: ltc2983: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-04-23 15:42 ` Andy Shevchenko
2024-05-02 11:41 ` Nuno Sá
2024-04-23 15:20 ` [PATCH v2 3/4] iio: backend: make use of dev_err_cast_probe() Nuno Sa via B4 Relay
2024-04-23 15:20 ` [PATCH v2 4/4] iio: common: scmi_iio: convert to dev_err_probe() Nuno Sa via B4 Relay
2024-04-23 15:50 ` Andy Shevchenko
2024-05-02 11:33 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8bf342ecd988f4c3cdeebb6f16da61a60c4454.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris@chrisdown.name \
--cc=gregkh@linuxfoundation.org \
--cc=jbhayana@google.com \
--cc=jic23@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox