Re: [PATCH] usb: dwc3: xilinx: include linux/gpio/consumer.h

[Michal Simek <michal.simek@amd.com>]

On 1/3/23 13:17, Arnd Bergmann wrote:
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added gpio consumer calls cause a build failure in configurations
> that fail to include the right header implicitly:

I think it would be better to say what you have done exactly to make sure that 
developers will run it before they send the patch.


> 
> drivers/usb/dwc3/dwc3-xilinx.c: In function 'dwc3_xlnx_init_zynqmp':
> drivers/usb/dwc3/dwc3-xilinx.c:207:22: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_clk_get_optional'? [-Werror=implicit-function-declaration]
>    207 |         reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
>        |                      ^~~~~~~~~~~~~~~~~~~~~~~
>        |                      devm_clk_get_optional
> 
> Fixes: ca05b38252d7 ("usb: dwc3: xilinx: Add gpio-reset support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/usb/dwc3/dwc3-xilinx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
> index 8607d4c23283..0745e9f11b2e 100644
> --- a/drivers/usb/dwc3/dwc3-xilinx.c
> +++ b/drivers/usb/dwc3/dwc3-xilinx.c
> @@ -13,6 +13,7 @@
>   #include <linux/of.h>
>   #include <linux/platform_device.h>
>   #include <linux/dma-mapping.h>
> +#include <linux/gpio/consumer.h>
>   #include <linux/of_gpio.h>

Origin patch added this header and I think it should be also removed as the part 
of this patch.


>   #include <linux/of_platform.h>
>   #include <linux/pm_runtime.h>
> --
> 2.39.0
> 

Thanks,
Michal