From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8642DC433DB for ; Fri, 15 Jan 2021 11:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EAFC235F9 for ; Fri, 15 Jan 2021 11:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbhAOLKL (ORCPT ); Fri, 15 Jan 2021 06:10:11 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:11545 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727842AbhAOLKK (ORCPT ); Fri, 15 Jan 2021 06:10:10 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DHJLw1C7KzMK1l; Fri, 15 Jan 2021 19:08:08 +0800 (CST) Received: from [10.174.176.61] (10.174.176.61) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Fri, 15 Jan 2021 19:09:23 +0800 Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse_param() To: =?UTF-8?Q?Michal_Koutn=c3=bd?= References: <20201218061755.121205-1-chenzhou10@huawei.com> <7804658e-7644-8edb-5ca8-0c97389c8c62@huawei.com> CC: , , , , From: chenzhou Message-ID: <4abe04f8-e7a9-ab2e-f5d1-bb569e2dc157@huawei.com> Date: Fri, 15 Jan 2021 19:09:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.61] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On 2021/1/15 18:08, Michal Koutný wrote: > On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou wrote: >> Yeah, this will select all enabled controllers, but which doesn't the behavior we want. > I see what the issue is now. > >> See above. Just the mount behavior isn't what we what. > I agree this a bug and your I find your approach correct > > Reviewed-by: Michal Koutný I have sent the v3, which updates the description and add Fixes. [v3]: https://lore.kernel.org/patchwork/patch/1365535/ If it is ok for you to add Reviewed-by there. Thanks, Chen Zhou > >> The behavior was changed since commit f5dfb5315d34 ("cgroup: take >> options parsing into ->parse_monolithic()"), will add this as Fixes. > Thanks. > > Michal