From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F221C433B4 for ; Tue, 6 Apr 2021 03:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 331E961394 for ; Tue, 6 Apr 2021 03:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240019AbhDFDYi (ORCPT ); Mon, 5 Apr 2021 23:24:38 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15550 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbhDFDYh (ORCPT ); Mon, 5 Apr 2021 23:24:37 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FDt9M209bzPlyy; Tue, 6 Apr 2021 11:21:43 +0800 (CST) Received: from [10.67.110.136] (10.67.110.136) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Tue, 6 Apr 2021 11:24:23 +0800 Subject: Re: [PATCH] firmware: qcom-scm: Fix QCOM_SCM configuration To: Greg KH CC: , , , , , , References: <20210331064941.134333-1-heying24@huawei.com> From: "heying (H)" Message-ID: <4abf2891-87f3-ffe5-db36-059d31ac3761@huawei.com> Date: Tue, 6 Apr 2021 11:24:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.136] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, ÔÚ 2021/4/2 22:25, Greg KH дµÀ: > On Wed, Mar 31, 2021 at 02:49:41AM -0400, He Ying wrote: >> When CONFIG_QCOM_SCM is y while CONFIG_HAVE_ARM_SMCCC >> is not set, compiling errors are encountered as follows: >> >> drivers/firmware/qcom_scm-smc.o: In function `__scm_smc_do_quirk': >> qcom_scm-smc.c:(.text+0x36): undefined reference to `__arm_smccc_smc' >> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call': >> qcom_scm-legacy.c:(.text+0xe2): undefined reference to `__arm_smccc_smc' >> drivers/firmware/qcom_scm-legacy.o: In function `scm_legacy_call_atomic': >> qcom_scm-legacy.c:(.text+0x1f0): undefined reference to `__arm_smccc_smc' >> >> So add dependency on HAVE_ARM_SMCCC in QCOM_SCM configuration. >> >> Reported-by: Hulk Robot >> Signed-off-by: He Ying >> --- >> drivers/firmware/Kconfig | 1 + >> 1 file changed, 1 insertion(+) > What commit caused this problem to show up? Please add a "Fixes:" tag > in here and resend. OK. I'll resend. Thanks.