From: Florian Fainelli <f.fainelli@gmail.com>
To: Herve Codina <herve.codina@bootlin.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Yury Norov <yury.norov@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] lib/bitmap: Fix bitmap_scatter() and bitmap_gather() kernel doc
Date: Tue, 12 Mar 2024 09:39:22 -0700 [thread overview]
Message-ID: <4ad2bfc0-531e-4d66-b071-9bb983d8051b@gmail.com> (raw)
In-Reply-To: <20240312173556.4727ebbf@bootlin.com>
On 3/12/24 09:35, Herve Codina wrote:
> Hi Andy,
>
> On Tue, 12 Mar 2024 17:43:00 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
>> On Tue, Mar 12, 2024 at 05:42:11PM +0200, Andy Shevchenko wrote:
>>> On Tue, Mar 12, 2024 at 09:54:03AM +0100, Herve Codina wrote:
>>>> The make htmldoc command failed with the following error
>>>> ... include/linux/bitmap.h:524: ERROR: Unexpected indentation.
>>>> ... include/linux/bitmap.h:524: CRITICAL: Unexpected section title or transition.
>>>>
>>>> Move the visual representation to a literal block.
>>
>> ...
>>
>>>> This patch fixes de5f84338970 ("lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers")
>>>> available in net-next and linux-next
>>>
>>> Not sure about rules of net-next, but I would add Fixes FWIW:
>>>
>>> Fixes: de5f84338970 ("lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers")
>
> I think I cannot add the Fixes tag as the de5f84338970 commit is not yet
> merged in Torvald's tree and I am not sure that the commit hash will not
> change during the merge process.
That is not a reason for not providing a Fixes tag, it does not have to
be in Linus' tree.
As a matter of fact, let us consider someone doing a back port of your
patches into their custom local tree, they would like to have that
information that this patch fixes a problem introduced by an earlier
commit so they can take the entire set of commits as a whole.
--
Florian
next prev parent reply other threads:[~2024-03-12 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 8:54 [PATCH] lib/bitmap: Fix bitmap_scatter() and bitmap_gather() kernel doc Herve Codina
2024-03-12 15:42 ` Andy Shevchenko
2024-03-12 15:43 ` Andy Shevchenko
2024-03-12 16:35 ` Herve Codina
2024-03-12 16:39 ` Florian Fainelli [this message]
2024-03-12 17:42 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad2bfc0-531e-4d66-b071-9bb983d8051b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=herve.codina@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=thomas.petazzoni@bootlin.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox