From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Melody Olvera <quic_molvera@quicinc.com>,
Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm8750: Add LPASS macro codecs and pinctrl
Date: Fri, 21 Feb 2025 22:38:31 +0100 [thread overview]
Message-ID: <4ae230e9-021e-411d-add4-e7e1bfb2dfff@oss.qualcomm.com> (raw)
In-Reply-To: <20250220-sm8750-audio-v2-2-fbe243c4afc3@linaro.org>
On 20.02.2025 9:49 AM, Krzysztof Kozlowski wrote:
> Add LPASS macro codecs and LPASS TLMM pin controller on Qualcomm SM8750
> for proper sound support. These are fully compatible with earlier SM8550.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
[...]
> + lpass_vamacro: codec@7660000 {
> + compatible = "qcom,sm8750-lpass-va-macro", "qcom,sm8550-lpass-va-macro";
> + reg = <0x0 0x07660000 0x0 0x1000>;
The VA macro is 0x2000-long instead
> + clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
> + clock-names = "mclk",
> + "macro",
> + "dcodec";
> +
> + #clock-cells = <0>;
> + clock-output-names = "fsgen";
> + #sound-dai-cells = <1>;
> + };
> +
Looks reasonable otherwise
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-02-21 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:49 [PATCH v2 0/4] arm64: dts: qcom: sm8750: Initial audio support (not yet complete) Krzysztof Kozlowski
2025-02-20 8:49 ` [PATCH v2 1/4] arm64: dts: qcom: sm8750: Add IPCC, SMP2P, AOSS and ADSP Krzysztof Kozlowski
2025-02-20 8:49 ` [PATCH v2 2/4] arm64: dts: qcom: sm8750: Add LPASS macro codecs and pinctrl Krzysztof Kozlowski
2025-02-21 21:38 ` Konrad Dybcio [this message]
2025-02-20 8:49 ` [PATCH v2 3/4] arm64: dts: qcom: sm8750-mtp: Enable ADSP Krzysztof Kozlowski
2025-02-21 21:38 ` Konrad Dybcio
2025-02-20 8:49 ` [PATCH v2 4/4] arm64: dts: qcom: sm8750-qrd: " Krzysztof Kozlowski
2025-02-21 21:38 ` Konrad Dybcio
2025-02-20 12:36 ` [PATCH v2 0/4] arm64: dts: qcom: sm8750: Initial audio support (not yet complete) Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae230e9-021e-411d-add4-e7e1bfb2dfff@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox