From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122AbeDBGHi (ORCPT ); Mon, 2 Apr 2018 02:07:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37278 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbeDBGHf (ORCPT ); Mon, 2 Apr 2018 02:07:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 14C48602FC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sricharan@codeaurora.org Subject: Re: [PATCH v5 07/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 board file To: Bjorn Andersson Cc: mark.rutland@arm.com, robh@kernel.org, devicetree@vger.kernel.org, marc.zyngier@arm.com, catalin.marinas@arm.com, richardcochran@gmail.com, will.deacon@arm.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, david.brown@linaro.org, absahu@codeaurora.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, linux-soc@vger.kernel.org, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org References: <1521800336-19266-1-git-send-email-sricharan@codeaurora.org> <1521800336-19266-8-git-send-email-sricharan@codeaurora.org> <20180327171414.GJ1403@tuxbook-pro> From: Sricharan R Message-ID: <4af1f110-ccbf-872f-21fd-d0557b6e6b1b@codeaurora.org> Date: Mon, 2 Apr 2018 11:37:23 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180327171414.GJ1403@tuxbook-pro> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/27/2018 10:44 PM, Bjorn Andersson wrote: > On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote: >> +#include "qcom-ipq4019-ap.dk04.1.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C3"; > > Add a compatible to the board file. > ok. > Also, things like alias would make sense to put in the board unless > there's some restriction making every board having the same layout. > >> +}; hmm. i also thought of having them in board specific files initially. In this case, at-least the aliases for serial nodes seems to match across dk-01/04/07 base variants. But might be if we add something else in future it might not be common. Yeah, would move it to board specific files. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation