Re: [PATCH] pci_find_device --> pci_get_device [only marks deprecation]

Re: [PATCH] pci_find_device --> pci_get_device [only marks deprecation]

[Jiri Slaby]

On 7/19/05, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> Jiri Slaby wrote:
> >* Marks the function as deprecated in pci.h
[it is meant pci_find_device]
>
> This is a very good idea in my eyes.

2.6.13-rc3-mm2

Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>

diff --git a/include/linux/pci.h b/include/linux/pci.h
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -754,7 +754,7 @@ void pci_setup_cardbus(struct pci_bus *b

  /* Generic PCI functions exported to card drivers */

-struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from);
+struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from) __deprecated;
  struct pci_dev *pci_find_device_reverse (unsigned int vendor, unsigned int device, const struct pci_dev *from);
  struct pci_dev *pci_find_slot (unsigned int bus, unsigned int devfn);
  int pci_find_capability (struct pci_dev *dev, int cap);

Re: [PATCH] pci_find_device --> pci_get_device [only marks deprecation]

[Jiri Slaby]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

On 7/28/05, Jiri Slaby <xslaby@fi.muni.cz> wrote:
> On 7/19/05, Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
> > Jiri Slaby wrote:
> > >* Marks the function as deprecated in pci.h
> [it is meant pci_find_device]
> >
> > This is a very good idea in my eyes.
> 
> 2.6.13-rc3-mm2
> 
> Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -754,7 +754,7 @@ void pci_setup_cardbus(struct pci_bus *b
> 
>   /* Generic PCI functions exported to card drivers */
> 
> -struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from);
> +struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from) __deprecated;
>   struct pci_dev *pci_find_device_reverse (unsigned int vendor, unsigned int device, const struct pci_dev *from);
>   struct pci_dev *pci_find_slot (unsigned int bus, unsigned int devfn);
>   int pci_find_capability (struct pci_dev *dev, int cap);

Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>

There are some additional spaces in the text patch, so repost with an
attachement.

[-- Attachment #2: lnx-pci_find-depr-6.13r3m2.patch --]
[-- Type: application/octet-stream, Size: 690 bytes --]

diff --git a/include/linux/pci.h b/include/linux/pci.h
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -754,7 +754,7 @@ void pci_setup_cardbus(struct pci_bus *b
 
 /* Generic PCI functions exported to card drivers */
 
-struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from);
+struct pci_dev *pci_find_device (unsigned int vendor, unsigned int device, const struct pci_dev *from) __deprecated;
 struct pci_dev *pci_find_device_reverse (unsigned int vendor, unsigned int device, const struct pci_dev *from);
 struct pci_dev *pci_find_slot (unsigned int bus, unsigned int devfn);
 int pci_find_capability (struct pci_dev *dev, int cap);