From: Krzysztof Kozlowski <krzk@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, srk@ti.com
Subject: Re: [PATCH] dt-bindings: mfd: syscon: Add ti,am62p-cpsw-mac-efuse compatible
Date: Tue, 2 Apr 2024 20:06:27 +0200 [thread overview]
Message-ID: <4b1380a8-0136-4395-ba42-9bcff2e1bdb0@kernel.org> (raw)
In-Reply-To: <30065bdc-ccef-4610-b1c1-7661f801b8e9@ti.com>
On 02/04/2024 14:30, Siddharth Vadapalli wrote:
> On Tue, Apr 02, 2024 at 02:08:32PM +0200, Krzysztof Kozlowski wrote:
>> On 02/04/2024 12:57, Siddharth Vadapalli wrote:
>>> The CTRLMMR_MAC_IDx registers within the CTRL_MMR space of TI's AM62p SoC
>>> contain the MAC Address programmed in the eFuse. Add compatible for
>>> allowing the CPSW driver to obtain a regmap for the CTRLMMR_MAC_IDx
>>> registers within the System Controller device-tree node. The default MAC
>>> Address for the interface corresponding to the first MAC port will be set
>>> to the value programmed in the eFuse.
>>>
>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>> ---
>>>
>>> This patch is based on linux-next tagged next-20240402.
>>
>> Where is the DTS using it?
>
> The current implementation in the device-tree for older TI K3 SoCs is as
> follows:
>
> cpsw_port1: port@1 {
> reg = <1>;
> ti,mac-only;
> label = "port1";
> phys = <&phy_gmii_sel 1>;
> mac-address = [00 00 00 00 00 00];
> ti,syscon-efuse = <&wkup_conf 0x200>;
> };
>
> The "ti,syscon-efuse" property passes the reference to the System
> Controller node as well as the offset to the CTRLMMR_MAC_IDx registers
> within the CTRL_MMR space.
Please reference upstream DTS or lore link to patch under review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-02 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 10:57 [PATCH] dt-bindings: mfd: syscon: Add ti,am62p-cpsw-mac-efuse compatible Siddharth Vadapalli
2024-04-02 12:08 ` Krzysztof Kozlowski
2024-04-02 12:30 ` Siddharth Vadapalli
2024-04-02 18:06 ` Krzysztof Kozlowski [this message]
2024-04-03 5:35 ` Siddharth Vadapalli
2024-04-03 6:27 ` Krzysztof Kozlowski
2024-04-03 6:32 ` Siddharth Vadapalli
2024-04-03 6:40 ` Krzysztof Kozlowski
2024-04-03 6:48 ` Siddharth Vadapalli
2024-04-04 8:32 ` Siddharth Vadapalli
2024-04-05 5:21 ` Siddharth Vadapalli
2024-04-05 6:55 ` Krzysztof Kozlowski
2024-04-25 12:10 ` Siddharth Vadapalli
2024-05-02 10:01 ` Lee Jones
2024-05-02 10:02 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1380a8-0136-4395-ba42-9bcff2e1bdb0@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox