Re: [PATCH 07/36] tty/vt: consolemap: make parameters of inverse_translate() saner

Ilpo Järvinen
2022-06-07T13:32:45Z

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> - int use_unicode -> bool: it's used as bool at some places already, so
> make it explicit.
> - int glyph -> u16: every caller passes a u16 in. So make it explicit
> too. And remove a negative check from inverse_translate() as it never
> could be negative.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.