Re: [PATCH 20/36] tty/vt: consolemap: saner variable names in set_inverse_trans_unicode()

Ilpo Järvinen
2022-06-07T14:34:46Z

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> The function uses too vague variable names like i, j, k for iterators, p,
> q, p1, p2 for pointers etc.
>
> Rename all these, so that it is clear what is going on:
> - dict: for dictionaries.
> - d, r, g: for dir, row, glyph iterators -- these are unsigned now.
> - dir, row: for directory and row pointers.
> - glyph: for the glyph.
> - and so on...
>
> This is a lot of shuffling, but the result pays off, IMO.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.