Re: [PATCH 6/6] mshv: Introduce new hypercall to map stats page for L1VH partitions

[Easwar Hariharan <easwar.hariharan@linux.microsoft.com>]

On 9/5/2025 4:12 PM, Nuno Das Neves wrote:
> On 9/5/2025 12:50 PM, Easwar Hariharan wrote:
>> On 8/28/2025 5:43 PM, Nuno Das Neves wrote:
>>> From: Jinank Jain <jinankjain@linux.microsoft.com>
>>>
>>> Introduce HVCALL_MAP_STATS_PAGE2 which provides a map location (GPFN)
>>> to map the stats to. This hypercall is required for L1VH partitions,
>>> depending on the hypervisor version. This uses the same check as the
>>> state page map location; mshv_use_overlay_gpfn().
>>>
>>> Add mshv_map_vp_state_page() helpers to use this new hypercall or the
>>> old one depending on availability.
>>>
>>> For unmapping, the original HVCALL_UNMAP_STATS_PAGE works for both
>>> cases.
>>>
>>> Signed-off-by: Jinank Jain <jinankjain@linux.microsoft.com>
>>> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
>>> ---
>>>  drivers/hv/mshv_root.h         | 10 ++--
>>>  drivers/hv/mshv_root_hv_call.c | 92 ++++++++++++++++++++++++++++++++--
>>>  drivers/hv/mshv_root_main.c    | 25 +++++----
>>>  include/hyperv/hvgdk_mini.h    |  1 +
>>>  include/hyperv/hvhdk_mini.h    |  7 +++
>>>  5 files changed, 115 insertions(+), 20 deletions(-)
>>>

<snip>

>>
>> Shouldn't this be in the previous patch where the other hv_call_map_stat_page() calls were
>> converted, same below?
>>
> The previous patch converts hv_call_(un)map_vp_state_page to hv_(un)map_vp_state_page, i.e.
> "state" not "stats".
> 

Ugh, thanks for the catch. I guess my eyes glazed over a little bit with the diffs.

Thanks,
Easwar (he/him)