From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Wang <frawang.cn@gmail.com>,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
william.wu@rock-chips.com, tim.chen@rock-chips.com,
frank.wang@rock-chips.com
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576
Date: Fri, 27 Sep 2024 09:30:30 +0200 [thread overview]
Message-ID: <4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org> (raw)
In-Reply-To: <7944f4dd-96f0-40df-8c91-523409e3cb20@gmail.com>
On 27/09/2024 09:01, Frank Wang wrote:
> Hi Krzysztof,
>
> On 2024/9/26 22:19, Krzysztof Kozlowski wrote:
>> On 26/09/2024 12:32, Frank Wang wrote:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - rockchip,rk3576-usb2phy
>>> + then:
>>> + properties:
>>> + clocks:
>>> + minItems: 3
>>> + maxItems: 3
>> Read one more time the example I gave you. Top-level constraints are
>> saying max one clock.
>>
>> Best regards,
>> Krzysztof
>>
>
> Sorry for overlooking this, I will set both "clocks" and "clock-names"
> to true, and add the else case below the above codes for the "old" SoCs.
> Just like the below.
>
> - clocks:
> - maxItems: 1
> + clocks: true
>
> - clock-names:
> - const: phyclk
> + clock-names: true
For the third time, read the code I gave you. Do you see something like
this there? Why doing all the time something different than existing code?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-27 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:32 [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 Frank Wang
2024-09-26 10:32 ` [PATCH v3 2/2] phy: rockchip: inno-usb2: Add usb2 phys support for rk3576 Frank Wang
2024-09-26 10:48 ` Heiko Stuebner
2024-09-27 6:16 ` Frank Wang
2024-09-27 7:42 ` Heiko Stuebner
2024-09-26 14:19 ` [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 Krzysztof Kozlowski
2024-09-27 7:01 ` Frank Wang
2024-09-27 7:30 ` Krzysztof Kozlowski [this message]
2024-09-27 7:59 ` Frank Wang
2024-09-27 9:52 ` Krzysztof Kozlowski
2024-09-27 10:49 ` Frank Wang
2024-09-27 10:59 ` Frank Wang
2024-09-27 12:05 ` Krzysztof Kozlowski
2024-09-27 8:02 ` Heiko Stuebner
2024-09-27 9:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.wang@rock-chips.com \
--cc=frawang.cn@gmail.com \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tim.chen@rock-chips.com \
--cc=vkoul@kernel.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox