From: Jens Axboe <axboe@kernel.dk>
To: Michal Suchanek <msuchanek@suse.de>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Biggers <ebiggers@google.com>,
"J. Bruce Fields" <bfields@redhat.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Benjamin Coddington <bcodding@redhat.com>,
Ming Lei <ming.lei@redhat.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
Hou Tao <houtao1@huawei.com>,
Pavel Begunkov <asml.silence@gmail.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Hannes Reinecke <hare@suse.com>,
"Ewan D. Milne" <emilne@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v4 00/10] Fix cdrom autoclose
Date: Thu, 21 Nov 2019 12:00:03 -0700 [thread overview]
Message-ID: <4ba670de-80d4-130e-91f3-c6e1cc9c7a47@kernel.dk> (raw)
In-Reply-To: <cover.1574355709.git.msuchanek@suse.de>
On 11/21/19 10:13 AM, Michal Suchanek wrote:
> Hello,
>
> there is cdrom autoclose feature that is supposed to close the tray,
> wait for the disc to become ready, and then open the device.
>
> This used to work in ancient times. Then in old times there was a hack
> in util-linux which worked around the breakage which probably resulted
> from switching to scsi emulation.
>
> Currently util-linux maintainer refuses to merge another hack on the
> basis that kernel still has the feature so it should be fixed there.
> The code needs not be replicated in every userspace utility like mount
> or dd which has no business knowing which devices are CD-roms and where
> the autoclose setting is in the kernel.
This is a lot of code/churn (and even an fops addition...) to work around
a broken hw emulation, essentially. Why aren't we just pushing vmware
to fix this?
--
Jens Axboe
next prev parent reply other threads:[~2019-11-21 19:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 17:13 [PATCH v4 00/10] Fix cdrom autoclose Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 01/10] cdrom: add poll_event_interruptible Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 02/10] cdrom: factor out common open_for_* code Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 03/10] cdrom: wait for the tray to close Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 04/10] cdrom: export autoclose logic as a separate function Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 05/10] cdrom: unify log messages Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 06/10] bdev: reset first_open when looping in __blkget_dev Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 07/10] bdev: separate parts of __blkdev_get as helper functions Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 08/10] bdev: add open_finish Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 09/10] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 10/10] scsi: sr: wait for the medium to become ready Michal Suchanek
2019-11-21 19:00 ` Jens Axboe [this message]
2019-11-21 23:43 ` [PATCH v4 00/10] Fix cdrom autoclose Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba670de-80d4-130e-91f3-c6e1cc9c7a47@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=ebiggers@google.com \
--cc=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=jack@suse.cz \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+samsung@kernel.org \
--cc=ming.lei@redhat.com \
--cc=msuchanek@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox