From: Alexey Dobriyan <adobriyan@gmail.com>
To: Edward Liaw <edliaw@google.com>
Cc: Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE
Date: Thu, 16 May 2024 22:05:42 +0300 [thread overview]
Message-ID: <4bbc6001-bafe-4db9-83fe-e03ddce1eb26@p183> (raw)
> --- a/tools/testing/selftests/proc/proc-empty-vm.c
> +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> -#undef _GNU_SOURCE
> -#define _GNU_SOURCE
No! Don't do this. It makes individual test program non-standalone.
Right now you can copy it to some other machine which triggers test
fauilure, compile and start debugging instead of remembering which
stupid compile flags it requires.
NAK for /proc, sorry. I'd like to keep #define.
next reply other threads:[~2024-05-16 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 19:05 Alexey Dobriyan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-10 0:06 [PATCH v4 00/66] Define _GNU_SOURCE for sources using Edward Liaw
2024-05-10 0:07 ` [PATCH v4 45/66] selftests/proc: Drop define _GNU_SOURCE Edward Liaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bbc6001-bafe-4db9-83fe-e03ddce1eb26@p183 \
--to=adobriyan@gmail.com \
--cc=edliaw@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox