public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Crystal Wood <crwood@redhat.com>
To: Tomas Glozar <tglozar@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel	 <linux-trace-kernel@vger.kernel.org>,
	John Kacur <jkacur@redhat.com>,
	Luis Goncalves <lgoncalv@redhat.com>,
	Costa Shulyupin <costa.shul@redhat.com>,
	Wander Lairson Costa	 <wander@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 2/4] rtla/timerlat: Add --bpf-action option
Date: Mon, 20 Oct 2025 12:51:53 -0500	[thread overview]
Message-ID: <4bd0779b41a1e635d6bca738ba2d15ea708a03f9.camel@redhat.com> (raw)
In-Reply-To: <20251017144650.663238-3-tglozar@redhat.com>

On Fri, 2025-10-17 at 16:46 +0200, Tomas Glozar wrote:

> diff --git a/tools/tracing/rtla/src/timerlat_bpf.c b/tools/tracing/rtla/src/timerlat_bpf.c
> index 1d619e502c65..3c63bf7aa607 100644
> --- a/tools/tracing/rtla/src/timerlat_bpf.c
> +++ b/tools/tracing/rtla/src/timerlat_bpf.c
> @@ -7,6 +7,10 @@
>  
>  static struct timerlat_bpf *bpf;
>  
> +/* BPF object and program for action program */
> +static struct bpf_object *obj;
> +static struct bpf_program *prog;
> +
>  /*
>   * timerlat_bpf_init - load and initialize BPF program to collect timerlat data
>   */
> @@ -56,6 +60,10 @@ int timerlat_bpf_init(struct timerlat_params *params)
>  		return err;
>  	}
>  
> +	/* Set BPF action program to NULL */
> +	prog = NULL;
> +	obj = NULL;

They should already be NULL...

-Crystal


  parent reply	other threads:[~2025-10-20 17:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 14:46 [PATCH 0/4] rtla/timerlat: Add --bpf-action option Tomas Glozar
2025-10-17 14:46 ` [PATCH 1/4] rtla/timerlat: Support tail call from BPF program Tomas Glozar
2025-10-17 14:46 ` [PATCH 2/4] rtla/timerlat: Add --bpf-action option Tomas Glozar
2025-10-20 14:04   ` Wander Lairson Costa
2025-10-20 17:51   ` Crystal Wood [this message]
2025-10-17 14:46 ` [PATCH 3/4] rtla/timerlat: Add example for BPF action program Tomas Glozar
2025-10-20 17:53   ` Crystal Wood
2025-10-21 14:54     ` Tomas Glozar
2025-10-21 15:58       ` Crystal Wood
2025-10-21 17:02         ` Steven Rostedt
2025-10-21 17:32           ` Crystal Wood
2025-10-23  7:27             ` Tomas Glozar
2025-10-24  1:49               ` Crystal Wood
2025-10-27 10:34                 ` Tomas Glozar
2025-10-27 12:30                   ` Crystal Wood
2025-10-17 14:46 ` [PATCH 4/4] Documentation/rtla: Document --bpf-action option Tomas Glozar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bd0779b41a1e635d6bca738ba2d15ea708a03f9.camel@redhat.com \
    --to=crwood@redhat.com \
    --cc=acme@kernel.org \
    --cc=costa.shul@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglozar@redhat.com \
    --cc=wander@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox