From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6820274B3B for ; Thu, 30 Apr 2026 18:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777575003; cv=none; b=a+kz9IpZ5sSPvdbUiBJFQhkdt1bZ6zDcxm5TzMwovY4clMlX9npgb1D54sFIIIe1ZaorTMWbUFS2ye6lmfhwRTxyBaAaVvIrJ2Dp+bbq5XosMJRNlq0jFVswfYjfsxqoHYEUCJvpuMXpZnZmsKEjbSBqmR0+85eRST8dcIZjq5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777575003; c=relaxed/simple; bh=EVxBSe1cl6Hz0Z3bsdHs1uU5HbZhyoI+ifzwQrVlJGM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DwZMw85ZdtgZEcYwOdgUg08qlbb03J/Qs5Se2YEkWOEb9uyVgV4XEVRpH9wAM2YeWKJs99dGuYjontMUyaMV1x8nTt51ki1TzM/jDxpYlwgNUYpHolTgp1ZKg4T5gPRxdTavPU8+O3XrHEj4jJNiKIy0uHBC2or5nLFu68aI3Go= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RgxsQmm5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RgxsQmm5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777574999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hnKl9OZc44JsdkvruemasdPKEjlnDZ5531kZfhlSZpc=; b=RgxsQmm5GV/TePgd+Ryj4uLmgnVn6IyfJAEE0OJ3y4BBqty66zlDNtBZHuUOnvMBYBTbda Tw/dRfZzGEkj2LO13FFOv8PQev0bHGZ4AQq7iy/lMPS4aCqEKE813ATR0qye0/J1pl0d7h 9POM108dr5jMarXsjoJsubldLY75/Fg= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-ZgXDA_lSMfGrNQSityPE0A-1; Thu, 30 Apr 2026 14:49:58 -0400 X-MC-Unique: ZgXDA_lSMfGrNQSityPE0A-1 X-Mimecast-MFC-AGG-ID: ZgXDA_lSMfGrNQSityPE0A_1777574998 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8e8950b3ee1so347435985a.3 for ; Thu, 30 Apr 2026 11:49:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777574998; x=1778179798; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hnKl9OZc44JsdkvruemasdPKEjlnDZ5531kZfhlSZpc=; b=Bey0QRtWWNAeanxurjpZdvRRwKAekCX43CjqQr//ZyRlNpP4mpsr+tJs9WT3Smmd2G AT9EF8IK6fasuCynrUJC8SaOh/Tcq8ZGu6lHqjXAa9fvl6760ADIIC2KoUrPsVSYSz8p 0mI1K6azRRy0SVXqxo2i8r4qdKb1hTkYkUnjBEzr6UOu739HsHHokBbwXT3TKVqNnVM7 NIo52LD2j8w0VPTBPNNQCy1Lkle3VkixbM1v8wRLW8GH+UkJhfuNB74AJmo8mZ3eyJAb UFmAP0Aw+zx9qGNDfzueL3RWr8RBCig6+q5YVc8oV17xu/eoqGJx5ehm6/wIXwANiTD1 QUFg== X-Forwarded-Encrypted: i=1; AFNElJ9hAdBUWElSY7gUJ5TM3LAS0oYuwPR5zrNVIxcHRYXcQsGJN5sFQDJvWhZICILA3gPULYNz1LEO6ncFuBA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx80zYU4+S7R7uOp14Je/TBACgR14FKonMK8dGmQfMXsZ7Y7tZu DCuhGfwk87D+fYobHIAmTSoeTshcs3Ms98y3FKLnpHnD7h8rDyGMZP6oHmN1IhDC5OKxm31Oggl nALiTGVYvV1Kkm3Dn/sNDHK4Thd4amG0Ro80TZAmx/Xaj9VPf2zOde/2VrdaZbzcI5Q== X-Gm-Gg: AeBDiesgnxJIsFo5TscAgabDF+ZLr08+eVut7C6AXGKUyq8zzcXAqw3sBvg48gVOHQp S+/8JEU3Byg506FtX5y8mnh53O/WVI0FaKuH+0h6mstiFSqwg9B0RS5R8qwjRoRgTDbJR8/fWeh dReZxa89mmd8R9l4KO2xu4lxPygczaKlHZHJSeIeo4eixxZK/lONZgsVKt55Kpg9i5apl8oiQRh aE6YbPKu5O22Nu3jBquyTUIvucacKUHyd5f8HTiP3+Oza+/Ult1/ebBjmt3eXbFoWjw6WhHoi4y SlLzYeN27BkdYXaWJdxlBSsKr7RXV0zIg82Adbfl3iPCn0dMxbNeGDWAnaAqrbDc1pqYA0XB7M/ 136TgGGiwiQKjVe6Gga0036KXYrt/aV5ys8e8Z6OYJOqVdT4TSpZgv4k38FaS4Ge2kFkUvWrElX PGzvqDG/guGE5TqcVE1i4xndA= X-Received: by 2002:a05:620a:4803:b0:8d6:874c:a763 with SMTP id af79cd13be357-8fa8922add1mr662274985a.49.1777574997666; Thu, 30 Apr 2026 11:49:57 -0700 (PDT) X-Received: by 2002:a05:620a:4803:b0:8d6:874c:a763 with SMTP id af79cd13be357-8fa8922add1mr662269985a.49.1777574997162; Thu, 30 Apr 2026 11:49:57 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-22-70-53-202-134.dsl.bell.ca. [70.53.202.134]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fbb430fed8sm39960585a.41.2026.04.30.11.49.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 11:49:56 -0700 (PDT) Message-ID: <4beb6000-7d00-4ee6-a482-daa90c7502c3@redhat.com> Date: Thu, 30 Apr 2026 14:49:55 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 52/54] selftests/mm: va_high_addr_switch.sh: drop huge pages setup To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-53-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260428204240.1924129-53-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-28 16:42, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Since va_high_addr_switch takes care of setting up huge pages, there is > no need to set them up in the va_high_addr_switch.sh wrapper script. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Luiz Capitulino > --- > .../selftests/mm/va_high_addr_switch.sh | 41 +------------------ > 1 file changed, 1 insertion(+), 40 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > index 9492c2d72634..01c15fe3c799 100755 > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -9,7 +9,6 @@ > > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=4 > -orig_nr_hugepages=0 > > skip() > { > @@ -77,43 +76,5 @@ check_test_requirements() > esac > } > > -save_nr_hugepages() > -{ > - orig_nr_hugepages=$(cat /proc/sys/vm/nr_hugepages) > -} > - > -restore_nr_hugepages() > -{ > - echo "$orig_nr_hugepages" > /proc/sys/vm/nr_hugepages > -} > - > -setup_nr_hugepages() > -{ > - local needpgs=$1 > - while read -r name size unit; do > - if [ "$name" = "HugePages_Free:" ]; then > - freepgs="$size" > - break > - fi > - done < /proc/meminfo > - if [ "$freepgs" -ge "$needpgs" ]; then > - return > - fi > - local hpgs=$((orig_nr_hugepages + needpgs)) > - echo $hpgs > /proc/sys/vm/nr_hugepages > - > - local nr_hugepgs=$(cat /proc/sys/vm/nr_hugepages) > - if [ "$nr_hugepgs" != "$hpgs" ]; then > - restore_nr_hugepages > - skip "$0: no enough hugepages for testing" > - fi > -} > - > check_test_requirements > -save_nr_hugepages > -# The HugeTLB tests require 6 pages > -setup_nr_hugepages 6 > -./va_high_addr_switch --run-hugetlb > -retcode=$? > -restore_nr_hugepages > -exit $retcode > +./va_high_addr_switch