Re: [PATCH 6/6] watchdog: Prefix WDT with ICS for clarity

[Guenter Roeck <linux@roeck-us.net>]

On 5/4/26 04:02, Philipp Hahn wrote:
> From: Philipp Hahn <phahn-oss@avm.de>
> 
> `wdt.rst` is only about the Watchdog timer from "Industrial Computer
> Source" (ICS). Change the title to better express this.
> 

Please also explain "ICS" into the documentation file.

We can not rename the Kconfig symbol, but I'd also suggest to rename
the documentation to icswdt.rst or maybe better watchdog-ics.rst.

Additional comment below.

Thanks,
Guenter

> Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
> ---
>   Documentation/watchdog/wdt.rst | 6 +++---
>   drivers/watchdog/Kconfig       | 6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/watchdog/wdt.rst b/Documentation/watchdog/wdt.rst
> index d97b0361535b0..be8cc0b9f31e1 100644
> --- a/Documentation/watchdog/wdt.rst
> +++ b/Documentation/watchdog/wdt.rst
> @@ -1,6 +1,6 @@
> -============================================================
> -WDT Watchdog Timer Interfaces For The Linux Operating System
> -============================================================
> +================================================================
> +ICS WDT Watchdog Timer Interfaces For The Linux Operating System
> +================================================================
>   
>   Last Reviewed: 10/05/2007
>   
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index dc78729ba2a5d..2cbf0391a065a 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -2270,10 +2270,10 @@ config MIXCOMWD
>   	  Most people will say N.
>   
>   config WDT
> -	tristate "WDT Watchdog timer"
> +	tristate "ICS WDT Watchdog timer"

WDT is now redundant. Maybe "ICS WDT500P/WDT501P Watchdog timer" to
match the PCI variant.

>   	depends on ISA
>   	help
> -	  If you have a WDT500P or WDT501P watchdog board, say Y here,
> +	  If you have an ICS WDT500P or WDT501P watchdog board, say Y here,
>   	  otherwise N. It is not possible to probe for this board, which means
>   	  that you have to inform the kernel about the IO port and IRQ that
>   	  is needed (you can do this via the io and irq parameters)
> @@ -2304,7 +2304,7 @@ config PCIPCWATCHDOG
>   	  Most people will say N.
>   
>   config WDTPCI
> -	tristate "PCI-WDT500/501 Watchdog timer"
> +	tristate "ICS PCI-WDT500/501 Watchdog timer"
>   	depends on PCI && HAS_IOPORT
>   	help
>   	  If you have a PCI-WDT500/501 watchdog board, say Y here, otherwise N.