* Re: bridge/microchip_lvds panel usage [not found] <CAN9Xe3RV9aZLJ3zV3zip5MQweGbBghdOFGohd6Qg-XjvFoGing@mail.gmail.com> @ 2025-06-17 23:36 ` Laurent Pinchart 2025-06-18 3:50 ` Dharma.B 0 siblings, 1 reply; 4+ messages in thread From: Laurent Pinchart @ 2025-06-17 23:36 UTC (permalink / raw) To: Anusha Srivatsa Cc: dri-devel, manikandan.m, dharma.b, Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, linux-kernel On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote: > Hey folks, > > Can someone please explain why the driver looks for a panel here: > https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/ > microchip-lvds.c#L182 and doesnt use it or set it up anywhere? > > I bumped into this while working on converting of_drm_find_panel() callers and > the lvds->panel usage in this driver felt off. Am I missing something? That doesn't seem needed. By the way, please use plain text when posting to kernel mailing lists. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bridge/microchip_lvds panel usage 2025-06-17 23:36 ` bridge/microchip_lvds panel usage Laurent Pinchart @ 2025-06-18 3:50 ` Dharma.B 2025-06-18 8:55 ` Laurent Pinchart 0 siblings, 1 reply; 4+ messages in thread From: Dharma.B @ 2025-06-18 3:50 UTC (permalink / raw) To: laurent.pinchart, asrivats Cc: dri-devel, Manikandan.M, neil.armstrong, rfoss, jonas, jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied, simona, linux-kernel Hi Laurent & Anusha, On 18/06/25 5:06 am, Laurent Pinchart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote: >> Hey folks, >> >> Can someone please explain why the driver looks for a panel here: >> https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/ >> microchip-lvds.c#L182 and doesnt use it or set it up anywhere? >> >> I bumped into this while working on converting of_drm_find_panel() callers and >> the lvds->panel usage in this driver felt off. Am I missing something? > > That doesn't seem needed. Currently the LVDS controller driver is hardcoded to map LVDS lanes to the JEIDA format. In order to support the other format "VESA", we need this to query the panel driver and set the appropriate format accordingly. "drm_panel_get_modes(lvds->panel, connector)" We'll be submitting the patch upstream shortly. > > By the way, please use plain text when posting to kernel mailing lists. > > -- > Regards, > > Laurent Pinchart -- With Best Regards, Dharma B. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bridge/microchip_lvds panel usage 2025-06-18 3:50 ` Dharma.B @ 2025-06-18 8:55 ` Laurent Pinchart 2025-06-23 10:54 ` Dharma.B 0 siblings, 1 reply; 4+ messages in thread From: Laurent Pinchart @ 2025-06-18 8:55 UTC (permalink / raw) To: Dharma.B Cc: asrivats, dri-devel, Manikandan.M, neil.armstrong, rfoss, jonas, jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied, simona, linux-kernel On Wed, Jun 18, 2025 at 03:50:11AM +0000, Dharma.B@microchip.com wrote: > On 18/06/25 5:06 am, Laurent Pinchart wrote: > > On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote: > >> Hey folks, > >> > >> Can someone please explain why the driver looks for a panel here: > >> https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/ > >> microchip-lvds.c#L182 and doesnt use it or set it up anywhere? > >> > >> I bumped into this while working on converting of_drm_find_panel() callers and > >> the lvds->panel usage in this driver felt off. Am I missing something? > > > > That doesn't seem needed. > > Currently the LVDS controller driver is hardcoded to map LVDS lanes to > the JEIDA format. > > In order to support the other format "VESA", we need this to query the > panel driver and set the appropriate format accordingly. > > "drm_panel_get_modes(lvds->panel, connector)" It would be nice if this could be done using the bridge API instead. An LVDS sink does not necessarily need to be a panel. > We'll be submitting the patch upstream shortly. > > > By the way, please use plain text when posting to kernel mailing lists. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bridge/microchip_lvds panel usage 2025-06-18 8:55 ` Laurent Pinchart @ 2025-06-23 10:54 ` Dharma.B 0 siblings, 0 replies; 4+ messages in thread From: Dharma.B @ 2025-06-23 10:54 UTC (permalink / raw) To: laurent.pinchart Cc: asrivats, dri-devel, Manikandan.M, neil.armstrong, rfoss, jonas, jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied, simona, linux-kernel Hi Laurent, On 18/06/25 2:25 pm, Laurent Pinchart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Wed, Jun 18, 2025 at 03:50:11AM +0000, Dharma.B@microchip.com wrote: >> On 18/06/25 5:06 am, Laurent Pinchart wrote: >>> On Tue, Jun 17, 2025 at 10:36:34AM -0500, Anusha Srivatsa wrote: >>>> Hey folks, >>>> >>>> Can someone please explain why the driver looks for a panel here: >>>> https://elixir.bootlin.com/linux/v6.14.11/source/drivers/gpu/drm/bridge/ >>>> microchip-lvds.c#L182 and doesnt use it or set it up anywhere? >>>> >>>> I bumped into this while working on converting of_drm_find_panel() callers and >>>> the lvds->panel usage in this driver felt off. Am I missing something? >>> >>> That doesn't seem needed. >> >> Currently the LVDS controller driver is hardcoded to map LVDS lanes to >> the JEIDA format. >> >> In order to support the other format "VESA", we need this to query the >> panel driver and set the appropriate format accordingly. >> >> "drm_panel_get_modes(lvds->panel, connector)" > > It would be nice if this could be done using the bridge API instead. An > LVDS sink does not necessarily need to be a panel. Here is the updated patch https://lore.kernel.org/lkml/20250623-microchip-lvds-v2-1-8ecbabc6abc4@microchip.com/ I will send another patch to remove "lvds->panel" as it is unused. Thanks. > >> We'll be submitting the patch upstream shortly. >> >>> By the way, please use plain text when posting to kernel mailing lists. > > -- > Regards, > > Laurent Pinchart -- With Best Regards, Dharma B. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-23 10:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAN9Xe3RV9aZLJ3zV3zip5MQweGbBghdOFGohd6Qg-XjvFoGing@mail.gmail.com>
2025-06-17 23:36 ` bridge/microchip_lvds panel usage Laurent Pinchart
2025-06-18 3:50 ` Dharma.B
2025-06-18 8:55 ` Laurent Pinchart
2025-06-23 10:54 ` Dharma.B
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).