From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Chen Ni <nichen@iscas.ac.cn>,
kvalo@kernel.org, johannes.berg@intel.com, kees@kernel.org,
a@bayrepo.ru, wsa+renesas@sang-engineering.com,
quic_alokad@quicinc.com, marcan@marcan.st, j@jannau.net
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: cfg80211: Convert comma to semicolon
Date: Wed, 4 Sep 2024 16:43:17 +0200 [thread overview]
Message-ID: <4c1c9d54-3abc-41be-8d29-7cfc1680dc87@broadcom.com> (raw)
In-Reply-To: <20240904074637.1352864-1-nichen@iscas.ac.cn>
On 9/4/2024 9:46 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
Almost certainly not intended or at least I can not think of a reason
for that construct here so without further ado ....
> Found by inspection.
> No functional change intended.
> Compile tested only.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
next prev parent reply other threads:[~2024-09-04 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 7:46 [PATCH] wifi: brcmfmac: cfg80211: Convert comma to semicolon Chen Ni
2024-09-04 14:43 ` Arend van Spriel [this message]
2024-09-09 12:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1c9d54-3abc-41be-8d29-7cfc1680dc87@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=a@bayrepo.ru \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=j@jannau.net \
--cc=johannes.berg@intel.com \
--cc=kees@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=nichen@iscas.ac.cn \
--cc=quic_alokad@quicinc.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox