From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0298AC4332F for ; Tue, 13 Dec 2022 07:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234694AbiLMHib convert rfc822-to-8bit (ORCPT ); Tue, 13 Dec 2022 02:38:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234703AbiLMHiY (ORCPT ); Tue, 13 Dec 2022 02:38:24 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E120E1C10E; Mon, 12 Dec 2022 23:38:19 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id CF47D24E023; Tue, 13 Dec 2022 15:38:17 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 13 Dec 2022 15:38:17 +0800 Received: from [192.168.120.55] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 13 Dec 2022 15:38:16 +0800 Message-ID: <4c2ae045-9ece-3245-7203-2db21f604ac8@starfivetech.com> Date: Tue, 13 Dec 2022 15:38:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v1 2/3] mmc: starfive: Add sdio/emmc driver support Content-Language: en-US To: Shawn Lin CC: Rob Herring , Krzysztof Kozlowski , Jaehoon Chung , Ulf Hansson , , , , References: <20221207131731.1291517-1-william.qiu@starfivetech.com> <20221207131731.1291517-3-william.qiu@starfivetech.com> <26e9c3eb-aaeb-8cbd-dda0-20f28331dbeb@starfivetech.com> From: William Qiu In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/13 15:33, Shawn Lin wrote: > Hi > > On 2022/12/13 15:21, William Qiu wrote: >> >> >> On 2022/12/13 10:24, Shawn Lin wrote: >>> Hi >> >>> use ".common_caps = MMC_CAP_CMD23" instead. >>> >> >> Hi Shawn, >> >> Thank you for taking time to review. >> The .common_caps is not defined in dw_mci_drv_data. >> And .num_caps is also used in dw_mci-rockchip.c. >> > > That means your patch is based on old upstream kernel which hasn't > been updated for at least one year.:) > Sorry about that. I just check the code on 5.15. I will update it in next version. Thank you any way. >> Best regards, >> William Qiu >>>> +    .set_ios = dw_mci_starfive_set_ios, >>>> +    .parse_dt = dw_mci_starfive_parse_dt, >>>> +    .execute_tuning = dw_mci_starfive_execute_tuning, >>>> +}; >>>> + >>>> +static const struct of_device_id dw_mci_starfive_match[] = { >>>