Re: [PATCH v13 20/32] x86/resctrl: Read telemetry events

Reinette Chatre
2025-11-13T22:47:54Z

Hi Tony,

On 10/29/25 9:21 AM, Tony Luck wrote:
> @@ -217,3 +221,51 @@ void __exit intel_aet_exit(void)
> }
> }
> }
> +
> +#define DATA_VALID BIT_ULL(63)
> +#define DATA_BITS GENMASK_ULL(62, 0)
> +
> +/*
> + * Read counter for an event on a domain (summing all aggregators
> + * on the domain). If an aggregator hasn't received any data for a
> + * specific RMID, the MMIO read indicates that data is not valid.
> + * Return success if at least one aggregator has valid data.
> + */
> +int intel_aet_read_event(int domid, u32 rmid, enum resctrl_event_id eventid,
> + void *arch_priv, u64 *val)

Is eventid needed? It could perhaps be used as a sanity check of
pevt->id but if it is not used then it can be dropped.

Reinette