Re: [PATCH v13 08/32] x86,fs/resctrl: Rename struct rdt_mon_domain and rdt_hw_mon_domain

Reinette Chatre
2025-11-13T04:01:26Z

Hi Tony,

On 10/29/25 9:20 AM, Tony Luck wrote:
> The upcoming telemetry event monitoring are not tied to the L3

"are not tied" -> "is not tied"?

> resource and will have a new domain structures.

"a new domain structures" -> "new domain structures"?

Could you please review all changelogs, even those that already have
RB tag, to make full use of line length? This is required by tip and having
patches formatted correctly will reduce fixups needed later.

(This repeats
https://lore.kernel.org/lkml/22ee0370-2cdd-435e-a7d4-81dc0c3df547@intel.com/)

>
> Rename the L3 resource specific domain data structures to include
> "l3_" in their names to avoid confusion between the different
> resource specific domain structures:
> rdt_mon_domain -> rdt_l3_mon_domain
> rdt_hw_mon_domain -> rdt_hw_l3_mon_domain
>
> No functional change.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

...

> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 1a33d5e6ae23..a07542957e5a 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -178,7 +178,7 @@ struct mbm_cntr_cfg {
> };
>
> /**
> - * struct rdt_mon_domain - group of CPUs sharing a resctrl monitor resource
> + * struct rdt_l3_mon_domain - group of CPUs sharing a resctrl monitor resource

nit: The "a resctrl monitor" in the description can now be updated to reflect that
it is now L3 resource specific. For example, "group of CPUs sharing RDT_RESOURCE_L3
monitoring"

> * @hdr: common header for different domain types
> * @ci_id: cache info id for this domain
> * @rmid_busy_llc: bitmap of which limbo RMIDs are above threshold
> @@ -192,7 +192,7 @@ struct mbm_cntr_cfg {
> * @cntr_cfg: array of assignable counters' configuration (indexed
> * by counter ID)
> */
> -struct rdt_mon_domain {
> +struct rdt_l3_mon_domain {
> struct rdt_domain_hdr hdr;
> unsigned int ci_id;
> unsigned long *rmid_busy_llc;

...

> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 9f4c2f0aaf5c..6eca3d522fcc 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -60,17 +60,17 @@ struct rdt_hw_ctrl_domain {
> };
>
> /**
> - * struct rdt_hw_mon_domain - Arch private attributes of a set of CPUs that share
> - * a resource for a monitor function
> - * @d_resctrl: Properties exposed to the resctrl file system
> + * struct rdt_hw_l3_mon_domain - Arch private attributes of a set of CPUs that share
> + * a resource for a monitor function

Similar here. This is no longer just "a resource" but can only be an L3 resource.

Reinette