From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbdH3SJN (ORCPT ); Wed, 30 Aug 2017 14:09:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35124 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbdH3SJL (ORCPT ); Wed, 30 Aug 2017 14:09:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5C366085B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] acpi: apei: call into AER handling regardless of severity To: Borislav Petkov Cc: Sinan Kaya , Tony Luck , rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com, james.morse@arm.com, prarit@redhat.com, punit.agrawal@arm.com, shiju.jose@huawei.com, andriy.shevchenko@linux.intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Linux PCI , Huang Ying References: <1503940314-29526-1-git-send-email-tbaicar@codeaurora.org> <20170829082055.u3qpwtgyzxjxfvup@pd.tnic> <9abb2e99-44be-3315-47d9-2689b6c76d79@codeaurora.org> <20170829221932.ojkvr4y6s76hcpkj@pd.tnic> <0fb1fe1b-207a-93fe-4ac6-b886451e488e@codeaurora.org> <20170830101617.3m266q7xuew6ctxl@pd.tnic> <20170830151601.ro5qt5272e2msevp@pd.tnic> <20170830171440.3ynavu5nuchiwxcb@pd.tnic> From: "Baicar, Tyler" Message-ID: <4c8b05cc-c0c2-c78e-df0d-ce65ec789186@codeaurora.org> Date: Wed, 30 Aug 2017 12:09:05 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170830171440.3ynavu5nuchiwxcb@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/2017 11:14 AM, Borislav Petkov wrote: > On Wed, Aug 30, 2017 at 09:42:08AM -0600, Baicar, Tyler wrote: >> I think with my two patches we will have the desired functionality: >> >> GHES_SEV_CORRECTABLE -> AER_CORRECTABLE -> Print AER info, but do not call >> do_recovery >> >> GHES_SEV_RECOVERABLE -> AER_NONFATAL -> Print AER info and do_recovery >> >> GHES_RECOVERABLE and CPER_SEC_RESET -> AER_FATAL -> Print AER info and >> do_recover > Right, so I'd like to you create a separate function ghes_do_proc_aer() > or ghes_handle_aer() or so and carve out all the code inside #ifdef > CONFIG_ACPI_APEI_PCIEAER into it, add your two changes to the patch and > slap a big fat comment above the new function explaining *why* we're > doing what we're doing and how we're mapping all the severities to AER > severity in order to do recovery and/or only to print the error. > > So that it is known and people can see in the future why we're doing > this and what the logic has been and what kind of policy we're chasing > and so on and so on... > > Ok? > > Thanks. Yes, I can do that. Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.