Re: [PATCH v1 2/2] dt-bindings: arm: add property for coresight component name

[taozha@codeaurora.org]

On 2021-04-16 19:23, Alexander Shishkin wrote:
> Tao Zhang <taozha@codeaurora.org> writes:
> 
>> Add property "coresight-name" for coresight component name. This
>> allows coresight driver to read device name from device entries.
>> 
>> Signed-off-by: Tao Zhang <taozha@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/arm/coresight.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt 
>> b/Documentation/devicetree/bindings/arm/coresight.txt
>> index d711676..0e980ce 100644
>> --- a/Documentation/devicetree/bindings/arm/coresight.txt
>> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
>> @@ -103,6 +103,8 @@ its hardware characteristcs.
>>  	  powers down the coresight component also powers down and loses its
>>  	  context. This property is currently only used for the ETM 4.x 
>> driver.
>> 
>> +	* coresight-name: the name of the coresight devices.
> 
> Which devices? Also, is it a common practice to extend device tree
> definitions based on arbitrary driver needs, or should there be some
> sort of a discussion first?
> 
> Regards,
> --
> Alex
Through the device tree entries, we can define their own name for any 
coresight device. This design is mainly used to facilitate the unified 
naming of coresight devgies across targets. e.g, without this patch, we 
can only see from sysFS there are multiple funnels, but we cannot know 
which funnel it is based on their names from sysFS. After applying this 
patch, we can directly know what device it is by observing the device 
name in sysFS. And the common scripts can be developed, since applying 
this patch, the same coresight device can have the same name across 
targets. Each developer or vendor can define the name of each coresight 
device according to their preferences and products.

Tao