From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E554C433E2 for ; Fri, 4 Sep 2020 04:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10A7A206CA for ; Fri, 4 Sep 2020 04:00:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LivGR0bV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbgIDEAW (ORCPT ); Fri, 4 Sep 2020 00:00:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgIDEAS (ORCPT ); Fri, 4 Sep 2020 00:00:18 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D7AEC061244; Thu, 3 Sep 2020 21:00:17 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id d22so3884455pfn.5; Thu, 03 Sep 2020 21:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XMFEvqETbtFJPv2+OGPaMexSGTcaNeluPDMod6iYHAQ=; b=LivGR0bVhFREqzlrqnvlXldl+u7i+2YHwVAMsmK3mVu5yd8VGGTzNL5N9eCUrzUzAl QNgALXD0+LV8Yelg4AuntA/GNHsA91E53A/P/KTU1y+6IMB0kmSfJzNjXPTRX4UOWG4d pswGlvQsUGIEGxMkvGkjSVTlSzgXpUiq0NZ0l0psWuLsBJWFCXl8jMgIhmeGsTyDZXBT 2zQHlVM+k02bpZvMrFp01bGi6gRrwdAIMKQVavpzlOqTSXv2/VDLBK/Vgyl21npTP/YI P0Qdpz+8goCA8fRkvAReq1lhznkJUInnCgVz19WjdZLkU7W9RBupXA+7HJbd/uCbVKfe xoUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XMFEvqETbtFJPv2+OGPaMexSGTcaNeluPDMod6iYHAQ=; b=iBSWyWswcw9B48GI904Q4Kz3Njxuenbjn/Npm+07LlYvQ5vjF6J11aU+SGcO0pcoMN jaAvS68FXTfS0vHbXvZl2bw4mkyd3JQJypruuRgUdjzCG2my1JR0mohHB07ogIQs8rIx aTC7ZV+T6ZCxGf9/7OiYMpYdEStAhovFgNzVXDL1WPUQBNDD9l0WeX0d3nYU1EUk9EKy D9cpojRFJUzQ4J0CAxO41w9E+fTNH8o33iKpBPMEyeo7JNL4EgQ/HzICV83ODUZ2wYE8 VgQYzRtY/bfMeuKOBa3ziLeZTk3U9jeGDUhYvyeySAMvCvmz8pqo6px0QKnGv+gFsWj2 gyqw== X-Gm-Message-State: AOAM533kTaHGnp0mji2fG6G4SIpstfcQUjcuQhbZSBEr1EjL3Ip4S2nJ +vsRuXfQx0z1maL2LtUMGjohKZDZeos= X-Google-Smtp-Source: ABdhPJw63k5HRpzcCRjJ856JUHctr8zFE0JxXvdbdai8EeWZnKchPlwzUU2N+bAzatluHtVJmPjzNg== X-Received: by 2002:a63:595a:: with SMTP id j26mr5785667pgm.406.1599192016036; Thu, 03 Sep 2020 21:00:16 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id n26sm4774618pff.30.2020.09.03.21.00.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2020 21:00:15 -0700 (PDT) Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: Ensure that MDIO diversion is used To: Andrew Lunn Cc: netdev@vger.kernel.org, Vivien Didelot , "David S. Miller" , Jakub Kicinski , open list References: <20200902210328.3131578-1-f.fainelli@gmail.com> <20200903011324.GE3071395@lunn.ch> <28177f17-1557-bd69-e96b-c11c39d71145@gmail.com> <20200903220300.GH3112546@lunn.ch> From: Florian Fainelli Message-ID: <4cf621da-c917-bd4c-6d30-e8f145a24628@gmail.com> Date: Thu, 3 Sep 2020 21:00:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <20200903220300.GH3112546@lunn.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/3/2020 3:03 PM, Andrew Lunn wrote: >> The firmware provides the Device Tree but here is the relevant section for >> you pasted below. The problematic device is a particular revision of the >> silicon (D0) which got later fixed (E0) however the Device Tree was created >> after the fixed platform, not the problematic one. Both revisions of the >> silicon are in production. >> >> There should have been an internal MDIO bus created for that chip revision >> such that we could have correctly parented phy@0 (bcm53125 below) as child >> node of the internal MDIO bus, but you have to realize that this was done >> back in 2014 when DSA was barely revived as an active subsystem. The >> BCM53125 node should have have been converted to an actual switch node at >> some point, I use a mdio_boardinfo overlay downstream to support the switch >> as a proper b53/DSA switch, anyway. > > I was expecting something like that. I think this patch needs a > comment in the code explaining it is a workaround for a DT blob which > cannot be changed. Maybe also make it conditional on the board > compatible string? It is already targeted at the Broadcom pseudo PHY address (30) which is the one that needs diversion, I will update the patch description accordingly though. -- Florian