From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: Kushal Kothari <kushalkothari285@gmail.com>, gregkh@linuxfoundation.org
Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
fmdefrancesco@gmail.com, marcocesati@gmail.com,
straube.linux@gmail.com, philippesdixon@gmail.com,
manuelpalenzuelamerino@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, mike.rapoport@gmail.com,
kushalkotharitest@googlegroups.com,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast
Date: Fri, 22 Oct 2021 08:18:43 +0530 [thread overview]
Message-ID: <4cfb2624-4e64-2d7f-a1e7-5032a3078ec9@gmail.com> (raw)
In-Reply-To: <f350e30b1e09332dff896b6588d962aab9800a52.1634845504.git.kushalkothari285@gmail.com>
On 22-10-2021 01:27, Kushal Kothari wrote:
> Issue found with checkpatch.pl.
> Space after cast is not needes
*needed
>
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 88f6b7405106..fce3256cc275 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -922,7 +922,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_
> memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
>
> if (check_fwstate(pmlmepriv, WIFI_STATION_STATE))
> - psetstakey_para->algorithm = (unsigned char) psecuritypriv->dot11PrivacyAlgrthm;
> + psetstakey_para->algorithm = (unsigned char)psecuritypriv->dot11PrivacyAlgrthm;
> else
> GET_ENCRY_ALGO(psecuritypriv, sta, psetstakey_para->algorithm, false);
>
> @@ -951,7 +951,7 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 unicast_
> }
>
> init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
> - ph2c->rsp = (u8 *) psetstakey_rsp;
> + ph2c->rsp = (u8 *)psetstakey_rsp;
> ph2c->rspsz = sizeof(struct set_stakey_rsp);
> res = rtw_enqueue_cmd(pcmdpriv, ph2c);
> } else {
> @@ -1002,7 +1002,7 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, struct sta_info *sta, u8 enqueu
> }
>
> init_h2fwcmd_w_parm_no_rsp(ph2c, psetstakey_para, _SetStaKey_CMD_);
> - ph2c->rsp = (u8 *) psetstakey_rsp;
> + ph2c->rsp = (u8 *)psetstakey_rsp;
> ph2c->rspsz = sizeof(struct set_stakey_rsp);
>
> memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN);
> @@ -2027,7 +2027,7 @@ void rtw_setstaKey_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *pc
> {
>
> struct sta_priv *pstapriv = &padapter->stapriv;
> - struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *) (pcmd->rsp);
> + struct set_stakey_rsp *psetstakey_rsp = (struct set_stakey_rsp *)(pcmd->rsp);
> struct sta_info *psta = rtw_get_stainfo(pstapriv, psetstakey_rsp->addr);
>
> if (!psta)
> @@ -2042,7 +2042,7 @@ void rtw_setassocsta_cmdrsp_callback(struct adapter *padapter, struct cmd_obj *
> struct sta_priv *pstapriv = &padapter->stapriv;
> struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
> struct set_assocsta_parm *passocsta_parm = (struct set_assocsta_parm *)(pcmd->parmbuf);
> - struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *) (pcmd->rsp);
> + struct set_assocsta_rsp *passocsta_rsp = (struct set_assocsta_rsp *)(pcmd->rsp);
> struct sta_info *psta = rtw_get_stainfo(pstapriv, passocsta_parm->addr);
>
> if (!psta)
>
Regards,
~Praveen.
next prev parent reply other threads:[~2021-10-22 2:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 19:57 [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Kushal Kothari
2021-10-21 19:57 ` [PATCH 1/4] staging: rtl8723bs: core: Remove true and false comparison Kushal Kothari
2021-10-22 2:44 ` [Outreachy kernel] " Praveen Kumar
2021-11-03 11:52 ` Dan Carpenter
2021-10-21 19:57 ` [PATCH 2/4] staging: rtl8723bs: core: Remove unnecessary parentheses Kushal Kothari
2021-10-21 19:57 ` [PATCH 3/4] staging: rtl8723bs: core: Remove unnecessary space after a cast Kushal Kothari
2021-10-22 2:48 ` Praveen Kumar [this message]
2021-10-21 19:57 ` [PATCH 4/4] staging: rtl8723bs: core: Remove unnecessary blank lines Kushal Kothari
2021-10-22 6:03 ` Greg KH
2021-10-22 2:45 ` [Outreachy kernel] [PATCH 0/4] staging: rtl8723bs: core: Cleanup patchset for style issues in rtw_cmd.c Praveen Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cfb2624-4e64-2d7f-a1e7-5032a3078ec9@gmail.com \
--to=kpraveen.lkml@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kushalkothari285@gmail.com \
--cc=kushalkotharitest@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manuelpalenzuelamerino@gmail.com \
--cc=marcocesati@gmail.com \
--cc=mike.rapoport@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=philippesdixon@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox