Re: [PATCH v3 02/13] drm: xlnx: Fix kerneldoc

Tomi Valkeinen
2024-04-23T12:17:21Z

On 22/04/2024 21:45, Sean Anderson wrote:
> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
> members.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
> ---

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

Tomi

>
> Changes in v3:
> - Split off documentation for base pointers to previous commit
>
> Changes in v2:
> - New
>
> drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
> drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> index 09ea01878f2a..b18554467e9c 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.h
> @@ -53,6 +53,7 @@ enum zynqmp_dpsub_format {
> * @drm: The DRM/KMS device data
> * @bridge: The DP encoder bridge
> * @disp: The display controller
> + * @layers: Video and graphics layers
> * @dp: The DisplayPort controller
> * @dma_align: DMA alignment constraint (must be a power of 2)
> */
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.h b/drivers/gpu/drm/xlnx/zynqmp_kms.h
> index 01be96b00e3f..cb13c6b8008e 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.h
> +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.h
> @@ -22,9 +22,9 @@
> struct zynqmp_dpsub;
>
> /**
> - * struct zynqmp_dpsub - ZynqMP DisplayPort Subsystem DRM/KMS data
> + * struct zynqmp_dpsub_drm - ZynqMP DisplayPort Subsystem DRM/KMS data
> * @dpsub: Backpointer to the DisplayPort subsystem
> - * @drm: The DRM/KMS device
> + * @dev: The DRM/KMS device
> * @planes: The DRM planes
> * @crtc: The DRM CRTC
> * @encoder: The dummy DRM encoder