public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Mikhail Gavrilov" <mikhail.v.gavrilov@gmail.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: thomas.hellstrom@linux.intel.com,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	Ken.Xue@amd.com
Subject: Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some games stopped working.
Date: Sat, 9 Apr 2022 16:27:17 +0200	[thread overview]
Message-ID: <4d0cbb79-4955-a3ed-4aa2-7f6cdaa00481@gmail.com> (raw)
In-Reply-To: <CABXGCsNNwEjo_dvWJL7GLULBPy+RmwsC9ObpowR_M1nQ3fKt3g@mail.gmail.com>

Am 08.04.22 um 19:25 schrieb Mikhail Gavrilov:
> On Fri, 8 Apr 2022 at 19:27, Christian König <christian.koenig@amd.com> wrote:
>> Please test the attached patch, it just re-introduce the lock without
>> doing much else.
>>
>> And does your branch contain the following patch:
>>
>> commit d18b8eadd83e3d8d63a45f9479478640dbcfca02
>> Author: Christian König <christian.koenig@amd.com>
>> Date:   Wed Feb 23 14:35:31 2022 +0100
>>
>>       drm/amdgpu: install ctx entities with cmpxchg
>>
>>       Since we removed the context lock we need to make sure that not two
>> threads
>>       are trying to install an entity at the same time.
>>
>>       Signed-off-by: Christian König <christian.koenig@amd.com>
>>       Fixes: 461fa7b0ac565e ("drm/amdgpu: remove ctx->lock")
>>       Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>>       Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> The all listed games are now working with an attached patch.
> Also flood messages "WARNING: CPU: 31 PID: 51848 at
> drivers/dma-buf/dma-fence-array.c:191
> dma_fence_array_create+0x101/0x120" has gone.

That's unfortunately not the end of the story.

This is fixing your problem, but reintroducing the original problem that 
we call the syncobj with a lock held which can crash badly as well.

Going to take a closer look on Monday. I hope you can test a few more 
patches to help narrow down what's actually going wrong here.

Thanks,
Christian.

>
> Thanks.
>
> Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
>


  reply	other threads:[~2022-04-09 14:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 18:39 [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some games stopped working Mikhail Gavrilov
2022-04-04  6:30 ` Christian König
2022-04-04  8:22   ` Paul Menzel
2022-04-04  8:38     ` Christian König
2022-04-08 11:01   ` Mikhail Gavrilov
2022-04-08 11:13     ` Christian König
2022-04-08 12:24       ` Mikhail Gavrilov
2022-04-08 14:27         ` Christian König
2022-04-08 17:25           ` Mikhail Gavrilov
2022-04-09 14:27             ` Christian König [this message]
2022-04-15  5:38               ` Mikhail Gavrilov
2022-04-15  8:04                 ` Christian König
2022-05-11  9:05                   ` Mikhail Gavrilov
2022-05-11 12:01                     ` Christian König
2022-10-17 22:43                       ` Mikhail Gavrilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d0cbb79-4955-a3ed-4aa2-7f6cdaa00481@gmail.com \
    --to=ckoenig.leichtzumerken@gmail.com \
    --cc=Ken.Xue@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikhail.v.gavrilov@gmail.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox