From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, bgoswami@quicinc.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/9] ASoC: qdsp6: audioreach: topology use idr_alloc_u32
Date: Wed, 26 Oct 2022 10:19:44 +0100 [thread overview]
Message-ID: <4d2fcabe-291a-9f8d-ca48-eaf52e00695e@linaro.org> (raw)
In-Reply-To: <35f55696-c4c5-1f00-dc7e-b5c7dcf0a091@linux.intel.com>
Thanks Pierre,
On 21/10/2022 18:09, Pierre-Louis Bossart wrote:
>
>
> On 10/21/22 11:51, Srinivas Kandagatla wrote:
>> SubGraph and Module Instance ids take 32 bits, so use idr_alloc_u32
>> instead of idr_alloc to able to accomdate valid ranges.
>
> typo: accommodate.
>
will fix it in next version
> Also worth checking https://www.kernel.org/doc/html/latest/core-api/idr.html
> "The IDR interface is deprecated; please use the XArray instead."
Thanks for this hit, this looks really good and specially lookups
without Locking, this could cleanup the code a bit.
Having said that I would still like this patch go as it is with idr for
now, and I can plan to rework on converting idr to xa later, as there
are few more Qcom Audio drivers that have usage of idr.
thanks,
srini
>
>
next prev parent reply other threads:[~2022-10-26 9:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 16:51 [PATCH v2 0/9] ASoC: qdsp6: audioreach: add multi-port, SAL and MFC support Srinivas Kandagatla
2022-10-21 16:51 ` [PATCH v2 1/9] ASoC: qdsp6: audioreach: topology use idr_alloc_u32 Srinivas Kandagatla
2022-10-21 17:09 ` Pierre-Louis Bossart
2022-10-26 9:19 ` Srinivas Kandagatla [this message]
2022-10-26 20:38 ` Pierre-Louis Bossart
2022-10-21 16:52 ` [PATCH v2 2/9] ASoC: qdsp6: audioreach: remove unused connection_list Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 3/9] ASoC: qdsp6: audioreach: update dapm kcontrol private data Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 4/9] ASoC: qdsp6: audioreach: Simplify handing FE and BE graph connections Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 5/9] ASoC: qdsp6: audioreach: simplify module_list sz calculation Srinivas Kandagatla
2022-10-21 17:13 ` Pierre-Louis Bossart
2022-10-21 16:52 ` [PATCH v2 6/9] ASoC: qdsp6: audioreach: add support for more port connections Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 7/9] ASoC: qdsp6: audioreach: add support to enable SAL Module Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 8/9] ASoC: qdsp6: audioreach: add support for MFC Module Srinivas Kandagatla
2022-10-21 16:52 ` [PATCH v2 9/9] ASoC: qdsp6: audioreach: add support to enable module command Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d2fcabe-291a-9f8d-ca48-eaf52e00695e@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox