Re: [PATCH v2 3/3] mctp pcc: Implement MCTP over PCC Transport

Jakub Kicinski
2024-06-19T23:26:44Z

On Wed, 19 Jun 2024 16:05:52 -0400 admiyo@os.amperecomputing.com wrote:
> From: Adam Young <admiyo@amperecomputing.com>
>
> Implementation of DMTF DSP:0292
> Management Control Transport Protocol(MCTP) over
> Platform Communication Channel(PCC) network driver.
>
> MCTP devices are specified by entries in DSDT/SDST and
> reference channels specified in the PCCT.
>
> Communication with other devices use the PCC based
> doorbell mechanism.

This patch breaks allmodconfig build:

drivers/net/mctp/mctp-pcc.c:116:6: warning: unused variable 'rc' [-Wunused-variable]
116 | int rc;
| ^~
drivers/net/mctp/mctp-pcc.c:344:3: error: field designator 'owner' does not refer to any field in type 'struct acpi_driver'
344 | .owner = THIS_MODULE,
| ~^~~~~~~~~~~~~~~~~~~

In addition, please make sure you don't add new checkpatch warnings,
use:

./scripts/checkpatch.pl --strict --max-line-length=80 $patch

Please wait with the repost until next week, unless you get a review
from Jeremy before that. When reposting start a new thread, don't
repost in reply to previous posting. Instead add a lore link to the
previous version, like this:

https://lore.kernel.org/20240619200552.119080-1-admiyo@os.amperecomputing.com/

See also:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
--
pw-bot: cr