Re: [PATCH 1/3] mctp pcc: Implement MCTP over PCC Transport

Andrew Lunn
2024-05-13T20:22:14Z

> +struct mctp_pcc_hw_addr {
> + int inbox_index;
> + int outbox_index;
> +};

> +static void mctp_pcc_setup(struct net_device *ndev)
> +{
> + ndev->type = ARPHRD_MCTP;
> + ndev->hard_header_len = 0;
> + ndev->addr_len = sizeof(struct mctp_pcc_hw_addr);

Another reason you should be using u32. ndev->addr_len is going to
vary between 32 and 64 bit systems. I also wounder if when calling
dev_addr_set() these need to be byte swapped? Does the specification
define this?

Andrew