Re: [PATCH v2 3/3] mctp pcc: Implement MCTP over PCC Transport

Adam Young
2024-06-20T03:24:48Z

On 6/19/24 19:26, Jakub Kicinski wrote:
> On Wed, 19 Jun 2024 16:05:52 -0400 admiyo@os.amperecomputing.com wrote:
>> From: Adam Young <admiyo@amperecomputing.com>
>>
>> Implementation of DMTF DSP:0292
>> Management Control Transport Protocol(MCTP) over
>> Platform Communication Channel(PCC) network driver.
>>
>> MCTP devices are specified by entries in DSDT/SDST and
>> reference channels specified in the PCCT.
>>
>> Communication with other devices use the PCC based
>> doorbell mechanism.
> This patch breaks allmodconfig build:
>
> drivers/net/mctp/mctp-pcc.c:116:6: warning: unused variable 'rc' [-Wunused-variable]
> 116 | int rc;
> | ^~

Funny, I see that only when building on x86_64, not on arm64.  I will fix.

> drivers/net/mctp/mctp-pcc.c:344:3: error: field designator 'owner' does not refer to any field in type 'struct acpi_driver'
> 344 | .owner = THIS_MODULE,
> | ~^~~~~~~~~~~~~~~~~~~

Not sure how you are getting that last error.  I do not, and the v6.9.3
code base has this in include/acpi/acpi_bus.h at line 166

struct acpi_driver {
char name[80];
char class[80];
const struct acpi_device_id *ids; /* Supported Hardware IDs */
unsigned int flags;
struct acpi_device_ops ops;
struct device_driver drv;
struct module *owner;
};

> In addition, please make sure you don't add new checkpatch warnings,
> use:
>
> ./scripts/checkpatch.pl --strict --max-line-length=80 $patch
That runs clean.
>
> Please wait with the repost until next week, unless you get a review
> from Jeremy before that. When reposting start a new thread, don't
> repost in reply to previous posting. Instead add a lore link to the
> previous version, like this:
>
> https://lore.kernel.org/20240619200552.119080-1-admiyo@os.amperecomputing.com/
>
> See also:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested