From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Miaohe Lin <linmiaohe@huawei.com>, Lisa Wang <wyihan@google.com>
Cc: rientjes@google.com, seanjc@google.com, ackerleytng@google.com,
vannapurve@google.com, michael.roth@amd.com, jiaqiyan@google.com,
tabba@google.com, dave.hansen@linux.intel.com,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>, Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH RFC v2 2/7] mm: memory_failure: Allow truncate_error_folio to return MF_DELAYED
Date: Mon, 13 Apr 2026 21:18:13 +0200 [thread overview]
Message-ID: <4d38d333-d446-40a3-b6f4-c4890bfd24cf@kernel.org> (raw)
In-Reply-To: <5c5dfa85-baab-5c0f-6f6d-b71abbe10ed8@huawei.com>
On 4/7/26 05:55, Miaohe Lin wrote:
> On 2026/4/4 6:31, Lisa Wang wrote:
>> [...snip...]
>>>
>>> Will it be better to add a pr_info here to provide some information for users?
>>>
>>> Thanks.
>>> .
>> I think we don't need to add pr_info here; truncate_error_folio() always
>> leads to action_result, which already logs the recovery status.
>
> No strong opinion but I want to make code style more consistent with sth. like below:
>
Yeah, would be cleaner.
> if (err == MF_DELAYED)
> pr_info xxx
> else if (err != 0)
> pr_info("%#lx: Failed to punch page: %d\n", pfn, err);
> else if (!filemap_release_folio(folio, GFP_NOIO))
> pr_info("%#lx: failed to release buffers\n", pfn);
Maybe we can even make the failed here a "Failed" ;)
--
Cheers,
David
next prev parent reply other threads:[~2026-04-13 19:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 23:30 [PATCH RFC v2 0/7] mm: Fix MF_DELAYED handling on memory failure Lisa Wang
2026-03-19 23:30 ` [PATCH RFC v2 1/7] mm: memory_failure: Clarify the MF_DELAYED definition Lisa Wang
2026-03-22 21:34 ` Jiaqi Yan
2026-03-23 21:18 ` Lisa Wang
2026-03-19 23:30 ` [PATCH RFC v2 2/7] mm: memory_failure: Allow truncate_error_folio to return MF_DELAYED Lisa Wang
2026-03-30 7:02 ` Miaohe Lin
2026-04-03 22:31 ` Lisa Wang
2026-04-07 3:55 ` Miaohe Lin
2026-04-13 19:18 ` David Hildenbrand (Arm) [this message]
2026-04-14 23:02 ` Lisa Wang
2026-03-19 23:30 ` [PATCH RFC v2 3/7] mm: shmem: Update shmem handler to the MF_DELAYED definition Lisa Wang
2026-03-19 23:30 ` [PATCH RFC v2 4/7] mm: memory_failure: Generalize extra_pins handling to all MF_DELAYED cases Lisa Wang
2026-03-19 23:30 ` [PATCH RFC v2 5/7] mm: selftests: Add shmem memory failure test Lisa Wang
2026-03-21 6:30 ` Baolin Wang
2026-03-24 0:43 ` Lisa Wang
2026-03-24 12:36 ` Baolin Wang
2026-03-28 0:40 ` Lisa Wang
2026-03-30 7:12 ` Miaohe Lin
2026-03-19 23:30 ` [PATCH RFC v2 6/7] KVM: selftests: Add memory failure tests in guest_memfd_test Lisa Wang
2026-03-30 7:20 ` Miaohe Lin
2026-03-19 23:30 ` [PATCH RFC v2 7/7] KVM: selftests: Test guest_memfd behavior with respect to stage 2 page tables Lisa Wang
2026-03-20 2:39 ` [PATCH RFC v2 0/7] mm: Fix MF_DELAYED handling on memory failure Andrew Morton
2026-04-13 19:18 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d38d333-d446-40a3-b6f4-c4890bfd24cf@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=jiaqiyan@google.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=michael.roth@amd.com \
--cc=nao.horiguchi@gmail.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tabba@google.com \
--cc=vannapurve@google.com \
--cc=vbabka@kernel.org \
--cc=wyihan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox