From: Shiping Ji <shiping.linux@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Scott Branden <scott.branden@broadcom.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Luck <tony.luck@intel.com>,
Yuqing Shen <yuqing.shen@broadcom.com>,
Lei Wang <lewan@microsoft.com>, James Morse <james.morse@arm.com>,
Robert Richter <rrichter@marvell.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: EDAC driver for DMC520
Date: Tue, 7 Jan 2020 11:59:05 -0800 [thread overview]
Message-ID: <4d58e327-d732-8a6a-2606-728278ccf4d0@gmail.com> (raw)
In-Reply-To: <20200107195606.GM29542@zn.tnic>
On 1/7/2020 11:56 AM, Borislav Petkov wrote:
> On Tue, Jan 07, 2020 at 11:18:42AM -0800, Shiping Ji wrote:
>>> If Lei is coming back soon then it may be best to wait for her?
>
> Whoops, I made her a "he". Lei, sorry about that.
>
> You add your SOB under the original author's one:
>
> From: Lei Wang <leiwang_git@outlook.com>
>
> <commit message>
>
> Signed-off-by: Lei Wang <leiwang_git@outlook.com>
> Signed-off-by: you
>
> The kernel tree is full of examples. git log is your friend.
>> Yes, I followed the notes but apparently have missed some important
>> steps. I'll go the above document and get it fixed.
>
> Yes, it would be time well spent if you intend to deal with submitting
> patches to the kernel in the future.
>
> Thx.
>
Thanks Boris for the clear instructions! I went through the document and understood the rationale of SOB now. I'll add mine in my next patches.
--
Best regards,
Shiping Ji
prev parent reply other threads:[~2020-01-07 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:57 EDAC driver for DMC520 Scott Branden
2020-01-07 18:49 ` Borislav Petkov
2020-01-07 18:55 ` Scott Branden
2020-01-07 19:01 ` Shiping Ji
2020-01-07 19:13 ` Scott Branden
2020-01-07 19:18 ` Shiping Ji
2020-01-07 19:56 ` Borislav Petkov
2020-01-07 19:59 ` Shiping Ji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d58e327-d732-8a6a-2606-728278ccf4d0@gmail.com \
--to=shiping.linux@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=lewan@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rrichter@marvell.com \
--cc=scott.branden@broadcom.com \
--cc=tony.luck@intel.com \
--cc=yuqing.shen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox