Re: [PATCH v2 1/3] dt-bindings: display: add Chipwealth CH1115 OLED Controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/08/2026 16:34, Nicolás Antinori wrote:
> +
> +properties:
> +  compatible:
> +    const: chipwealth,ch1115
> +
> +  reg:
> +    maxItems: 1
> +
> +  chipwealth,invert:

Do not come with own style.
git grep invert: -- Documentation/devicetree/bindings/display/
git grep inverted: -- Documentation/devicetree/bindings/display/

so chipwealth,inverted.


> +    type: boolean
> +    description:
> +      Display pixels are inverted, i.e. 0 is white and 1 is black.
> +
> +  chipwealth,offset:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 63
> +    description:
> +      Display start line offset. Specifies the vertical alignment and row shift along the
> +      Y-coordinate.

Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).  However don't wrap blindly (see Kernel coding style).

Missing "default:"

> +
> +  chipwealth,contrast:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 255
> +    description:
> +      Panel contrast.

I do not get why this should be fixed property. Contrast feels like
runtime adjustable feature.

> +
> +  width-mm: true
> +  height-mm: true
> +  flip-horizontal: true
> +  flip-vertical: true
> +  panel-timing: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - width-mm
> +  - height-mm
> +  - panel-timing
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;

> +      status = "okay";

Drop, does not exist in bindings.

Please use existing, recently added code as an example/base.

> +
> +      display@3c {
> +        compatible = "chipwealth,ch1115";
> +        reg = <0x3c>;
> +        width-mm = <12>;
> +        height-mm = <8>;
> +        chipwealth,contrast = <127>;
> +        chipwealth,offset = <8>;
> +        panel-timing {
> +          clock-frequency = <0>;
> +          hactive = <88>;
> +          vactive = <48>;
> +          hfront-porch = <0>;
> +          hback-porch = <0>;
> +          hsync-len = <0>;
> +          vsync-len = <0>;
> +          vfront-porch = <0>;
> +          vback-porch = <0>;
> +        };
> +      };
> +    };
Best regards,
Krzysztof