Re: [PATCH v5 03/10] dt-bindings: media: Add amlogic,c3-mipi-adapter.yaml

Keke Li
2024-12-27T07:40:17Z

Hi Krzysztof

Thanks for your reply

On 2024/12/27 15:20, Krzysztof Kozlowski wrote:
> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> On 27/12/2024 08:09, Keke Li via B4 Relay wrote:
>> From: Keke Li <keke.li@amlogic.com>
>>
>> c3-mipi-adapter is used to organize mipi data and
>> send raw data to ISP module.
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: Keke Li <keke.li@amlogic.com>
>> ---
>> .../bindings/media/amlogic,c3-mipi-adapter.yaml | 115 +++++++++++++++++++++
>> MAINTAINERS | 6 ++
>> 2 files changed, 121 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
>> new file mode 100644
>> index 000000000000..1105fee2d7a8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml
>> @@ -0,0 +1,115 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 MIPI adapter receiver
>> +
>> +maintainers:
>> + - Keke Li <keke.li@amlogic.com>
>> +
>> +description:
>> + MIPI adapter is used to convert the MIPI CSI-2 data
>> + into an ISP supported data format.
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - amlogic,c3-mipi-adapter
>> +
>> + reg:
>> + maxItems: 3
>> +
>> + reg-names:
>> + items:
>> + - const: top
>> + - const: fd
>> + - const: rd
>> +
>> + power-domains:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: vapb
>> + - const: isp0
>> +
>> + assigned-clocks: true
>> +
>> + assigned-clock-rates: true
> NAK. Drop my review tag. You cannot keep someone's review while making
> significant changes. Please carefully read submitting patches before
> next posting.

OK, I see

Thanks!

>
> Best regards,
> Krzysztof