From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08AF327FD40 for ; Mon, 24 Nov 2025 13:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763989639; cv=none; b=iJNpNIu2AarbW72B93iKRfGhO/7ZucVi7Q6rAqCfqL3n7+JB5G/+DwrEWBkm6CwEVjGsAGlg0CmJiCuPIebAShQceFiaHbWufjx44jv0NnsXAuKNRYIzdNkNb73KL18HoI9ypIdGxhy8cN1/CbEjNntWx4J6ZdAaLf/GMgdqZ7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763989639; c=relaxed/simple; bh=LFLwSLvla9h6ILg+cRWILezDdFb/taYKuyCkiqMrV5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZhaauRlryCyrRMDC/QSDF9HQ9hefSGF2POrVliqibIUUmolqyBVAEQ9qw5eNHoJxrIko/WUTmSbtr7LPLtx7FJKBhRV5AH+curUloKSmP5uKA/YUOMRKwingPyWbXtXvbMbrriD9IFqFIabR8PBI3cu1tdDtX93wKBF9KlwL4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RxbioY7N; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RxbioY7N" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2958db8ae4fso42772545ad.2 for ; Mon, 24 Nov 2025 05:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763989637; x=1764594437; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eKDBEWppWKgZXVk9naXtMVTvTD+iNGRYthAd9NDpUBI=; b=RxbioY7NTgjtfj6Oiq6w03GlQ3LgaOP4MpZlGLeQhQ2LHCcO3O+Y6P1H6ZjY5R50o8 bAJaqzYhnCvayTUVQF3iqxsTVy77cwmxaEusERDxvkrr53JVx7q3XEfyrS41XKfdYL0w ZqzR1rdj9cQk5iYtlRGz4U58oVnwKYLeOp+rBMCYqS1UxHaI/XG3yE4pa1KSEDgbAc1i 4u1qDP8uJR910+fkIZopvKBNVfQpx4gdNWqSQlKJYoWFXvdgZwK+NQel0wqQpP6DBvHE dGNNIVf/lvUofTtQlUXrZlJQbilv3KBbQoQT+Ma68/nmfjrR9aU2zaQEXED8Sh7IoeWJ VLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763989637; x=1764594437; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eKDBEWppWKgZXVk9naXtMVTvTD+iNGRYthAd9NDpUBI=; b=GZvtnugrIGufEwZ9bbV1YGAVXof3ehKCsSO/hUCpwKpL+jp6QJIx6uX0+YbDbb6SWy tJXr3Hd6T+4c9wcNmv+woDEmLK+6Tspp0CGhGq646Ozx+QtG6Sx+gS+bdIcOoMucRPjv Bv1/0+ihUdSA8J5RlEciEYNBhl0tzVH3aMOnNkD1h1v9W6UtdSRhzRM89EuRcLGeCJuf raRC79jgOxZEHQRDqUfzFeE/cnjk3Mt+h+1TexDohAe4w9wuci7cFlRhneZHth2+/ZGw +yaS7lUVfdk8owC81EniTjE1YxYp0QL3I+5qwwFY3dFgj6jwDhAgq7QVlNQ2Qr1An7tL /Lyg== X-Forwarded-Encrypted: i=1; AJvYcCUaRoBta8yVNBAUMaIQHZHKl7/MIV69RKCafGsPiT+c6BVrXZpN65zhfbgyLU7bwGhmki2AiqnTNRbCunM=@vger.kernel.org X-Gm-Message-State: AOJu0YzKOkIb2vc6N5xRplNzjM8juVVRlHO+dKsgkOKU4FSYGneUvGOV H1H5ksx+WDsS93ZbjoEcu7yEQW2+DFB3EbyHGwF0mqHbAQJ2sugJUNjR X-Gm-Gg: ASbGncvx6O/Q1zy5AOq/gBbux9UfwDlfFTIFfY1IfEsohen01E71AzsCUl0I044atNU 9W9wGgMECEbJFjsmfmm0OQEd0pFNFdD2ibLjJ3LYPu1ybQLJejaWaGbWSseE/g4IfgMDsNJLGiz KOJgGAsG57Qnysc/RMCYS6PawZZNs0S286b9F0Uk8/3QWQDh+QkBiX7diTEJ/AfoaRlLtYomZcL hI7rXVzi4PLAjPdAcow6ObG5M/FGbONzQjSOs2uy3UlL0wolVm/e0lz5C5wz63je/nMact1ctEa 27PE/QnwAunk515tm98psmeOc7t5j42UM3KVX9Fc7b0N4SnoqFgraQfMTvPDzlw1WoN4gxG0jY3 V5WwgOY+E4EcW7ooY/W3AVZ83zVQLamAZqxsai70Odu54de+WItY9M9GEl4/8wgSExFJ9jcUdlT 656/r08cOXB5CAyOgpieeVitHkfaDCv+AmF3iVDAjyNAlqTrEhmrQKDl2O4nKu2I9kavyNiWMGw Q18RKMfchkBnI0mwsKg1Wox X-Google-Smtp-Source: AGHT+IGYN/r8oBndMZKJary0NXzIUVYqopsfyp9AtFvshWybB7U2BPq+Q+uB29yd3ds5KWxfyGNUtQ== X-Received: by 2002:a17:903:40ca:b0:299:dd98:fac2 with SMTP id d9443c01a7336-29b6c6b2646mr152991625ad.54.1763989637287; Mon, 24 Nov 2025 05:07:17 -0800 (PST) Received: from [192.168.2.119] ([103.92.100.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25e4basm133596575ad.47.2025.11.24.05.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 05:07:16 -0800 (PST) Message-ID: <4d7139b4-1f06-4efa-b930-5955dd3c78f4@gmail.com> Date: Mon, 24 Nov 2025 18:37:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] staging: rtl8723bs: replace FIELD_OFFSET usage with offsetof To: david laight , Dan Carpenter Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251122174555.215109-1-knavaneeth786@gmail.com> <20251122174555.215109-3-knavaneeth786@gmail.com> <20251124091754.7147dc66@pumpkin> <20251124121302.2d1988b6@pumpkin> Content-Language: en-US From: Navaneeth K In-Reply-To: <20251124121302.2d1988b6@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Dan, Hi David, Thanks for the clarification. I’ll remove the unused macro entirely in v2 instead of adjusting the cast. Regards, Navaneeth K On 24-11-2025 17:43, david laight wrote: > On Mon, 24 Nov 2025 12:45:46 +0300 > Dan Carpenter wrote: > >> On Mon, Nov 24, 2025 at 09:17:54AM +0000, david laight wrote: >>> On Mon, 24 Nov 2025 11:08:35 +0300 >>> Dan Carpenter wrote: >>> >>>> On Sat, Nov 22, 2025 at 05:45:52PM +0000, Navaneeth K wrote: >>>>> Replace usage of the custom FIELD_OFFSET macro with the standard >>>>> offsetof() macro in drv_types.h. This improves code readability and >>>>> standardization. >>>>> >>>>> Signed-off-by: Navaneeth K >>>>> --- >>>>> drivers/staging/rtl8723bs/include/drv_types.h | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h >>>>> index dd9018aa4ee5..47cabf8707f6 100644 >>>>> --- a/drivers/staging/rtl8723bs/include/drv_types.h >>>>> +++ b/drivers/staging/rtl8723bs/include/drv_types.h >>>>> @@ -173,9 +173,9 @@ struct registry_priv { >>>>> >>>>> >>>>> /* For registry parameters */ >>>>> -#define RGTRY_OFT(field) ((u32)FIELD_OFFSET(struct registry_priv, field)) >>>>> +#define RGTRY_OFT(field) ((u32)offsetof(struct registry_priv, field)) >>>> These casts to u32 are bogus garbage. Delete them. >>> Dunno - they might be needed (or have been needed) to stop min() >>> complaining about type mismatch. >>> They can also stop expressions being evaluated as 64bit (on 64bit) >>> which may reduce code size. >>> But that is a bit subtle... >> Actually the macros are unused. Just delete them entirely. > Sounds good to me :-) > >> regards, >> dan carpenter >>