From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8F348AE1B for ; Wed, 6 May 2026 15:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079655; cv=none; b=LwOT+q7Aok5LhiPF5UUO3zt7xSg5661C/lV2N1Hdnw+NiwUVbfheZsOagXBMJBKxIhT+Z2lzYWHjxeqn/gq4cKZLyqs9KFFjFvYGRh6yaheuhl5FZAS2Wzp8N/P8GoffNPykECtuT8q6QLqErbfR23cXtiQj5dMDpizVqRMAw74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079655; c=relaxed/simple; bh=k4ICJE/CqwbZBOkSb6v5C22dLL5vXori7c8seA8w40o=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=EdX3MSjBiNYZZcEefrziA6E2eJFzE60XEUDwrPq2cl5kkQNOydzJZXSE9HqZ8ugq2j3UIQDR0KBM7NLRX5htyOdxbms+NSJJIDaLzUQIB73m1iifB6tShCs+T4gOXyP5yJasj1hAW2mCrzWaT36MU4kwmg/CfMmw4rUQfTxIY24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HmeMuTqB; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HmeMuTqB" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-445795cf6f1so4091726f8f.1 for ; Wed, 06 May 2026 08:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778079651; x=1778684451; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=0/W7qZT5O8z085sn4mW/UkbICY8RKtYfsrB4Yj1GnNQ=; b=HmeMuTqBE3o9ejwcMW8rNIQjHCvhRMgytvsenUcYYmJgzJ9cDlC64+JxgSnFPRk6rA E/7qaauhxAVvkjtTWNCAb23zDdeJHT95Jpo3H+M4JdXqon6Oa+hUhJl28PjIGmO01HDW NILK51mbmRHIVqSgk+UHj6Uwtnra4OJV4y4xkgedBY/Zl3bMSWPtzkisgmT8IWjCWY5b 0ycBFYMRyCgYmiGNRCUV/eblzED49nCBHIUegHzTb/3AMfVixKN0ZlBf6fp+zkNeo111 ilp2SZ3tUS4GRyccXJ1tkukoolTvQkKNiOFdYtBZL93XHnMcJAIhbInWSEcI15XMvOO4 NJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778079651; x=1778684451; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/W7qZT5O8z085sn4mW/UkbICY8RKtYfsrB4Yj1GnNQ=; b=E/yyASYxP/5pcdVF3Gh67mBeIVaWpuXh0JkVTP9TE+nj8F6SB/2TmttxFhgssLdAmN IH9NLajkeMYibaomtCw1K7C1efsN9S50lXaTP2bHUNrtUXeyku38NAsuJOlgonQBZRDr HexZfury14yDprTmNVakt9widHcBg8Sjp8plRGdgZFnF21ZR+Q9S4ETyyXJqAGACMEpd 0pHJyEYoT3wo6qzHTOzR0WhJsYwrfBSue6P4rHVzJLGwmiPd6YSSSVslpBBioDV2tmLl WcQmczHnFDTBIkR4/R8NBmUeNaGnM2viByk26QttZj5hKd953lrJqDINLplogXSiRcJL exEQ== X-Forwarded-Encrypted: i=1; AFNElJ8tqWOTUCxj6hTc1QLy0AVObnw0lIDdNFi+lIkDtvDyNLpKhV6WFOR3S1Pw7PuBRhzRIUBkjMETdkYInyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwULX5HApp0i7Io+DHsckGqxMbu++OTJKK79RInIvrJ5IhHK1a/ Bkxta0YF/QupzWKmiv/vBDbsazQddA9im7FgQ2FnZcI+Aseu6pDZkE8/fCd2px9rDEY= X-Gm-Gg: AeBDievbSIcjP+s0cx6NnCoW5RDisLV90PQWp6j1ybph8JfpSdqq/3Ktv94QAKnlTHk mNRlBQ3CX8xzBOzkcRvlntPu2DdNFjnRiE9LJyFrbNZuaWHd2AFN/7+lnRnb/Mbzj5jWPCa4hWD AETVO3BMxQSlgn2BPCg2RxSbOCBhZ9V1E0IuNX8hcaLmMsGsAM0JDYaJ+EmMM1ThxskJr1xzhSG r2PVXS4RMP4hTOkFwy5TOUnvQftfbvaBXHZfsPIHV2cBV1jauWlxzASb+uCcYJyKe1QLB6yn34g CJE5PAOzXGI7P2yEFp9vNqA7wDh6FehsvZJR5W7BUURAM/nC/W+V69U5HIl/n8ZYhbjUpSx4DXA Q+95O78rhsDo01RHg5t+4gaRFfV9EBwewH0BIo859QpIw5yHl4CTiOJg4kgWjc/mEilkfJu9Uw1 nz5Ms/1F1L/ry24RlCPj6HytU8FoTTFiZNh8hHDoeuEy2uXG7tSRSbXmqJbf/Wi9MyIWiYlVdAG wvYC9kUiGEs71v7F5EkHgMadEoW X-Received: by 2002:a05:6000:18a6:b0:43d:761d:5423 with SMTP id ffacd0b85a97d-4515ad767eamr7192146f8f.16.1778079650163; Wed, 06 May 2026 08:00:50 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45054b03df9sm12728674f8f.24.2026.05.06.08.00.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 08:00:49 -0700 (PDT) Message-ID: <4d77bbef-6350-48e1-93a5-d256fc8bc8cd@linaro.org> Date: Wed, 6 May 2026 17:00:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] phy: rockchip: inno-hdmi: Change TMDS rate handling to configure() ops To: Jonas Karlman , Vinod Koul , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260503172936.194003-1-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260503172936.194003-1-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/3/26 19:29, Jonas Karlman wrote: > The commit 10ed34d6eaaf ("phy: Add HDMI configuration options") > introduced a way for HDMI PHYs to be configured through the generic > phy_configure() function. > > This driver currently derives the TMDS character rate from the pixel > clock and the PHY bus width setting. However, no in-tree consumer of > this PHY has ever called phy_set_bus_width() to change the TMDS rate. > > Change the TMDS character rate handling to depend on the configure() ops > before any PHY consumer needs to configure a TMDS character rate that is > different from the pixel clock rate. > > Signed-off-by: Jonas Karlman > --- > A near future drm/rockchip: dw_hdmi: series plans to include a call to > phy_configure() to configure this HDMI PHYs TMDS character rate. > --- > drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 30 ++++++++++--------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c > index 1483907413fa..7f0563d4d482 100644 > --- a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c > +++ b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c > @@ -245,6 +245,7 @@ struct inno_hdmi_phy { > struct clk *phyclk; > unsigned long pixclock; > unsigned long tmdsclock; > + struct phy_configure_opts_hdmi hdmi_cfg; > }; > > struct pre_pll_config { > @@ -554,19 +555,10 @@ static inline void inno_update_bits(struct inno_hdmi_phy *inno, u8 reg, > static unsigned long inno_hdmi_phy_get_tmdsclk(struct inno_hdmi_phy *inno, > unsigned long rate) > { > - int bus_width = phy_get_bus_width(inno->phy); > - > - switch (bus_width) { > - case 4: > - case 5: > - case 6: > - case 10: > - case 12: > - case 16: > - return (u64)rate * bus_width / 8; > - default: > - return rate; > - } > + if (inno->hdmi_cfg.tmds_char_rate) > + return inno->hdmi_cfg.tmds_char_rate; > + > + return rate; Can't you keep both until dw-hdmi calls the configure op ? > } > > static irqreturn_t inno_hdmi_phy_rk3328_hardirq(int irq, void *dev_id) > @@ -602,6 +594,16 @@ static irqreturn_t inno_hdmi_phy_rk3328_irq(int irq, void *dev_id) > return IRQ_HANDLED; > } > > +static int inno_hdmi_phy_configure(struct phy *phy, > + union phy_configure_opts *opts) > +{ > + struct inno_hdmi_phy *inno = phy_get_drvdata(phy); > + > + inno->hdmi_cfg = opts->hdmi; > + > + return 0; > +} > + > static int inno_hdmi_phy_power_on(struct phy *phy) > { > struct inno_hdmi_phy *inno = phy_get_drvdata(phy); > @@ -668,6 +670,7 @@ static int inno_hdmi_phy_power_off(struct phy *phy) > > static const struct phy_ops inno_hdmi_phy_ops = { > .owner = THIS_MODULE, > + .configure = inno_hdmi_phy_configure, > .power_on = inno_hdmi_phy_power_on, > .power_off = inno_hdmi_phy_power_off, > }; > @@ -1392,7 +1395,6 @@ static int inno_hdmi_phy_probe(struct platform_device *pdev) > } > > phy_set_drvdata(inno->phy, inno); > - phy_set_bus_width(inno->phy, 8); > > if (inno->plat_data->ops->init) { > ret = inno->plat_data->ops->init(inno);