Re: 2.6.13-mm3

Sonny Rao
2005-09-13T06:02:46Z

On Tue, Sep 13, 2005 at 02:51:39AM +0200, Jiri Slaby wrote:
> Sonny Rao napsal(a):
>
> >On Mon, Sep 12, 2005 at 05:49:45PM -0400, Sonny Rao wrote:
> >
> >
> >>--- linux-2.6.13-mm3/drivers/char/hvc_console.c~orig 2005-09-12
> >>16:37:14.434077464 -0500
> >>+++ linux-2.6.13-mm3/drivers/char/hvc_console.c 2005-09-12
> >>16:37:25.466998360 -0500
> >>@@ -597,7 +597,7 @@ static int hvc_poll(struct hvc_struct *h
> >>
> >> /* Read data if any */
> >> for (;;) {
> >>- count = tty_buffer_request_room(tty, N_INBUF);
> >>+ int count = tty_buffer_request_room(tty, N_INBUF);
> >>
> >> /* If flip is full, just reschedule a later read */
> >> if (count == 0) {
> >>@@ -633,7 +633,7 @@ static int hvc_poll(struct hvc_struct *h
> >> tty_insert_flip_char(tty, buf[i], 0);
> >> }
> >>
> >>- if (tty->flip.count)
> >>+ if (tty->buf.tail->used)
> >>
> >>
> Is there any better way to gather this info? I think, that this was my
> bad idea. Some encapsulation needed.
>

I agree, this is ugly as hell. I don't know if the tty stuff was
ever supposed to be used this way. Given the revamp, and if this usage is
legal, perhaps the addition of a generic wrapper to the API is
warranted.

Sonny