Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badness in vsnprintf

Andrew Morton
2005-09-12T22:44:33Z

Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
>
> Hi,
>
> On 12/09/05, Alexander Nyberg <alexn@telia.com> wrote:
> >
> > Gah, I'm such a fantastic programmer.
> >
> > I don't know what mc is up to but the error checking in read_page_owner
> > is flawed wrt snprintf which could cause the 'size' argument to snprintf
> > to become negative and if so overwrite beyond 'buf'.
> >
> > Again, I fail to see how mc causes this to happen, but this fixes it
> > by proper error checking.
> >
> > Signed-off-by: Alexander Nyberg <alexn@telia.com>
>
> Thanks, patch solved problem.

Thanks.

> Here is version, that clean apply on 2.6.13-mm3. Can you review it?

That patch is all wordwrapped.

How doe sit differe from Alex's patch?