The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>, <nm@ti.com>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <rogerq@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<stable@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<srk@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-j722s-main: Disable "serdes_wiz0" and "serdes_wiz1"
Date: Sat, 12 Apr 2025 11:03:36 +0530	[thread overview]
Message-ID: <4d9746fb-5145-4195-94ce-f4b40bc19d0a@ti.com> (raw)
In-Reply-To: <28f1e0b7-9947-43f3-9a47-f3c6ecd69b91@ti.com>

On Fri, Apr 11, 2025 at 09:22:00PM +0530, Kumar, Udit wrote:
> Hi
> 
> On 4/11/2025 7:47 PM, Siddharth Vadapalli wrote:
> > On Fri, Apr 11, 2025 at 07:31:52PM +0530, Kumar, Udit wrote:

[...]

> > > Since you are disabling parent node.
> > > 
> > > Do you still want to carry status = "disabled" in child nodes serdes0 and
> > > serdes1.
> > I could drop it, but then the patches will look something like:
> > 1) Patch 1: Same as the first patch in this series
> > 2) Patch 2: Current patch + Remove status = "disabled" within serdes0/1
> > 3) Patch 3: Removed redundant status = "okay" within serdes0/1 in
> >              k3-j722s-evm.dts
> > 
> > Updated Patch 2 and the new Patch 3 mentioned above aren't necessarily a
> > complete "Fix" and have other changes in addition to the "Fix". For that
> > reason, the changes associated with the updated patch 2 and the new patch 3
> > could be a separate series, unless you believe that they should go
> > together in the current series. Please let me know.
> 
> I don't see any use case where serdes_wiz0 is enabled and serdes0 is
> disabled.
> 
> So your comment 3) is valid. you can take this clean up in other series
> 
> 
> For now
> 
> Reviewed-by: Udit Kumar <u-kumar1@ti.com>

I have posted the cleanup series at:
https://lore.kernel.org/r/20250412052712.927626-1-s-vadapalli@ti.com/
The cleanup series applies on top of the current series.

Regards,
Siddharth.

      reply	other threads:[~2025-04-12  5:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 10:36 [PATCH v2 0/2] J722S: Disable WIZ0 and WIZ1 in SoC file Siddharth Vadapalli
2025-04-08 10:36 ` [PATCH v2 1/2] arm64: dts: ti: k3-j722s-evm: Enable "serdes_wiz0" and "serdes_wiz1" Siddharth Vadapalli
2025-04-11 13:56   ` Kumar, Udit
2025-04-08 10:36 ` [PATCH v2 2/2] arm64: dts: ti: k3-j722s-main: Disable " Siddharth Vadapalli
2025-04-11 14:01   ` Kumar, Udit
2025-04-11 14:17     ` Siddharth Vadapalli
2025-04-11 15:52       ` Kumar, Udit
2025-04-12  5:33         ` Siddharth Vadapalli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d9746fb-5145-4195-94ce-f4b40bc19d0a@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=srk@ti.com \
    --cc=stable@vger.kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox